Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(types): parent property type annotation in the ImportAttribute node #10258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2024
Merged

fix(types): parent property type annotation in the ImportAttribute node #10258

merged 1 commit into from
Nov 3, 2024

Conversation

ota-meshi
Copy link
Contributor

PR Checklist

Overview

This PR fixes the ImportAttribute#parent type.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ota-meshi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Nov 1, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 2f2e0c4
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67243a9396299e000850924b
😎 Deploy Preview https://deploy-preview-10258--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 1, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2f2e0c4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@ota-meshi ota-meshi changed the title fix(types): ImportAttribute#parent type fix(types): parent property type annotation in the ImportAttribute node Nov 1, 2024
@ota-meshi ota-meshi changed the title fix(types): parent property type annotation in the ImportAttribute node fix(types): parent property type annotation in the ImportAttribute node Nov 1, 2024
@bradzacher bradzacher added the bug Something isn't working label Nov 3, 2024
@bradzacher bradzacher merged commit 0fde8f6 into typescript-eslint:main Nov 3, 2024
68 of 71 checks passed
@ota-meshi ota-meshi deleted the import-attribute-parent branch November 3, 2024 23:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: wrong ImportAttribute#parent type
2 participants
@ota-meshi @bradzacher