Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

rivea0
Copy link
Contributor

@rivea0 rivea0 commented Jan 5, 2025

PR Checklist

Overview

A small change to fix an incorrect variable name used in a comment in one of the code examples

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @rivea0!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

nx-cloud bot commented Jan 5, 2025

View your CI Pipeline Execution ↗ for commit aa9acb7.

Command Status Duration Result
nx test eslint-plugin --coverage=false ❌ Failed 6m 5s View ↗
nx test visitor-keys --coverage=false ✅ Succeeded <1s View ↗
nx test utils --coverage=false ✅ Succeeded <1s View ↗
nx run types:build ✅ Succeeded <1s View ↗
nx test typescript-eslint --coverage=false ✅ Succeeded 9s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 29s View ↗
nx test type-utils --coverage=false ✅ Succeeded <1s View ↗
nx test utils ✅ Succeeded <1s View ↗
Additional runs (23) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-01-05 15:41:37 UTC

Copy link

netlify bot commented Jan 5, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit aa9acb7
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/677aa584bb1c720008835258
😎 Deploy Preview https://deploy-preview-10613--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 5dedb1c into typescript-eslint:main Jan 6, 2025
56 of 61 checks passed
@rivea0 rivea0 deleted the patch-1 branch January 7, 2025 10:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants