chore: clean up ESLint config post `vitest` migration #11135

aryaemami59 · 2025-05-05T10:24:45Z

PR Checklist

Addresses an existing open issue: fixes Repo: clean up eslint.config.mjs post vitest migration #11132
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

typescript-eslint · 2025-05-05T10:24:48Z

Thanks for the PR, @aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2025-05-05T10:25:02Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`1551966`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/6825fffa27af400008951b63
😎 Deploy Preview	https://deploy-preview-11135--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (🔴 down 1 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

nx-cloud · 2025-05-05T10:25:36Z

View your CI Pipeline Execution ↗ for commit 1551966.

Command	Status	Duration	Result
`nx test eslint-plugin`	✅ Succeeded	6m 24s	View ↗
`nx run eslint-plugin:test -- --coverage`	✅ Succeeded	6m 38s	View ↗
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 19s	View ↗
`nx test type-utils`	✅ Succeeded	24s	View ↗
`nx test eslint-plugin-internal`	✅ Succeeded	11s	View ↗
`nx test visitor-keys`	✅ Succeeded	3s	View ↗
`nx run types:build`	✅ Succeeded	1s	View ↗
`nx test typescript-eslint`	✅ Succeeded	5s	View ↗
`Additional runs (26)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2025-05-15 15:08:44 UTC

…t-eslint into chore/cleanup-eslint-config

codecov · 2025-05-07T15:07:41Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.92%. Comparing base (af077a0) to head (1551966).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #11135   +/-   ##
=======================================
  Coverage   90.92%   90.92%           
=======================================
  Files         499      499           
  Lines       50845    50845           
  Branches     8384     8384           
=======================================
  Hits        46231    46231           
  Misses       4599     4599           
  Partials       15       15

Flag	Coverage Δ
unittest	`90.92% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…t-eslint into chore/cleanup-eslint-config

JoshuaKGoldberg

Thanks!

…t-eslint into chore/cleanup-eslint-config

JamesHenry · 2025-05-16T13:35:03Z

nx config wise this is a very confusing change tbh.

Please can you share your reasoning?

aryaemami59 · 2025-05-16T13:38:37Z

@JamesHenry why is it confusing? Or rather which part is confusing? I'm more than happy to elaborate.

JamesHenry · 2025-05-16T13:44:06Z

Why did you add the eslint plugin here? Only to then immediately remove it again here chore: update some package scripts and dependency config #10765
Executors and inferred plugins are two different approaches to the same problem, in this PR you are simultaneously increasing the usage of both
Why are you specifying that all usage of a specific executor depends upon specific tasks ("@nx/eslint:lint": { "dependsOn": ["eslint-plugin-internal:build", "typescript-eslint:build"]), that is a very unusual thing to do, and I don't think it's accurate here

The mixed usage and application and then seeming upcoming undoing of things is why I wanted to understand the broader reasoning here.

I think it's best if a publish a video on these concepts to bring us on the same page

aryaemami59 · 2025-05-16T13:48:21Z

@JamesHenry

Why did you add the eslint plugin here? Only to then immediately remove it again here chore: fix nx usage with lifecycle scripts across all projects #10765

That was actually done by mistake I just fixed it.

aryaemami59 · 2025-05-16T13:57:46Z

nx.json

+    },
+    {
+      "plugin": "@nx/eslint/plugin",
+      "include": ["packages/*"],
+      "options": {
+        "targetName": "lint"
+      }


Reference

aryaemami59 · 2025-05-16T14:05:23Z

nx.json

+    "@nx/eslint:lint": {
+      "dependsOn": ["eslint-plugin-internal:build", "typescript-eslint:build"],
+      "options": {
+        "noEslintrc": true,
+        "cache": true,
+        "eslintConfig": "{workspaceRoot}/eslint.config.mjs"
+      },
+      "outputs": ["{options.outputFile}"],
+      "cache": true
+    },


Without this repo:lint would not be cached unless We explicitly pass this configuration to the root project.json file.

aryaemami59 · 2025-05-16T14:10:48Z

nx.json

-        "eslint-plugin-internal:build",
-        "typescript-eslint:build"
-      ],
+      "dependsOn": ["eslint-plugin-internal:build", "typescript-eslint:build"],


We are only using typescript-eslint and eslint-plugin-internal inside the eslint.config.mjs file, therefore eslint-plugin:build is not needed here.

chore: cleanup ESLint config file

89e0650

aryaemami59 marked this pull request as ready for review May 5, 2025 10:29

aryaemami59 added 2 commits May 5, 2025 05:35

remove jiti

5938d9b

Merge branch 'main' of https://github.com/typescript-eslint/typescrip…

20b2c16

…t-eslint into chore/cleanup-eslint-config

Merge branch 'main' of https://github.com/typescript-eslint/typescrip…

9c57e2d

…t-eslint into chore/cleanup-eslint-config

JoshuaKGoldberg approved these changes May 12, 2025

View reviewed changes

JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label May 12, 2025

Merge branch 'main' of https://github.com/typescript-eslint/typescrip…

1551966

…t-eslint into chore/cleanup-eslint-config

JoshuaKGoldberg merged commit ff2a785 into typescript-eslint:main May 16, 2025
59 checks passed

JamesHenry mentioned this pull request May 16, 2025

chore: remove postinstall steps from CI to speed up prepare-install action #11219

Open

3 tasks

aryaemami59 commented May 16, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: clean up ESLint config post `vitest` migration #11135

chore: clean up ESLint config post `vitest` migration #11135

aryaemami59 commented May 5, 2025

typescript-eslint bot commented May 5, 2025

netlify bot commented May 5, 2025 •

edited

Loading

nx-cloud bot commented May 5, 2025 •

edited

Loading

codecov bot commented May 7, 2025 •

edited

Loading

JoshuaKGoldberg left a comment

JamesHenry commented May 16, 2025

aryaemami59 commented May 16, 2025

JamesHenry commented May 16, 2025

aryaemami59 commented May 16, 2025 •

edited

Loading

aryaemami59 May 16, 2025

aryaemami59 May 16, 2025

aryaemami59 May 16, 2025

chore: clean up ESLint config post vitest migration #11135

chore: clean up ESLint config post vitest migration #11135

Conversation

aryaemami59 commented May 5, 2025

PR Checklist

Overview

typescript-eslint bot commented May 5, 2025

netlify bot commented May 5, 2025 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

nx-cloud bot commented May 5, 2025 • edited Loading

codecov bot commented May 7, 2025 • edited Loading

Codecov Report

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

JamesHenry commented May 16, 2025

aryaemami59 commented May 16, 2025

JamesHenry commented May 16, 2025

aryaemami59 commented May 16, 2025 • edited Loading

aryaemami59 May 16, 2025

Choose a reason for hiding this comment

aryaemami59 May 16, 2025

Choose a reason for hiding this comment

aryaemami59 May 16, 2025

Choose a reason for hiding this comment

chore: clean up ESLint config post `vitest` migration #11135

chore: clean up ESLint config post `vitest` migration #11135

netlify bot commented May 5, 2025 •

edited

Loading

nx-cloud bot commented May 5, 2025 •

edited

Loading

codecov bot commented May 7, 2025 •

edited

Loading

aryaemami59 commented May 16, 2025 •

edited

Loading