Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: simplify tsconfig setup using configDir #11136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 12, 2025
Merged

chore: simplify tsconfig setup using configDir #11136

merged 3 commits into from
May 12, 2025

Conversation

aryaemami59
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented May 5, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 9faa185
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/681dfa19ddd64d0008b8a370
😎 Deploy Preview https://deploy-preview-11136--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 5, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 9faa185.

Command Status Duration Result
nx typecheck ast-spec ✅ Succeeded <1s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 1s View ↗
nx run-many --target=clean ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-09 13:06:48 UTC

@aryaemami59 aryaemami59 marked this pull request as ready for review May 5, 2025 10:58
@codecov Codecov
Copy link

codecov bot commented May 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.91%. Comparing base (e57126a) to head (9faa185).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11136   +/-   ##
=======================================
  Coverage   90.91%   90.91%           
=======================================
  Files         499      499           
  Lines       50809    50809           
  Branches     8369     8369           
=======================================
  Hits        46195    46195           
  Misses       4599     4599           
  Partials       15       15
Flag Coverage Δ
unittest 90.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes May 12, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I'd never used configDir before, very excited to see it here. +88 −357 is a lovely diff 😄 thank you!

@JoshuaKGoldberg JoshuaKGoldberg merged commit b2be3dc into typescript-eslint:main May 12, 2025
57 checks passed
@aryaemami59 aryaemami59 deleted the chore/simplify-tsconfig-setup branch May 15, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: simplify tsconfig setup using configDir
2 participants
@aryaemami59 @JoshuaKGoldberg