Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(eslint-plugin): [consistent-indexed-object-style] adjust auto-fixer to generate valid syntax for TSMappedType with no type annotation #11180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ronami
Copy link
Member

@ronami ronami commented May 6, 2025

PR Checklist

Overview

This PR addresses #11179 and adjusts the auto-fixer to fix the following:

type Bar = {
  [k in string];
};

Into:

type Bar = Record<string, any>;

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented May 6, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ccd2307
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/681a200990c19d00088f488a
😎 Deploy Preview https://deploy-preview-11180--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented May 6, 2025

View your CI Pipeline Execution ↗ for commit ccd2307.

Command Status Duration Result
nx typecheck ast-spec ✅ Succeeded <1s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 5s View ↗
nx run-many --target=clean ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-06 14:57:06 UTC

Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.91%. Comparing base (d5209cd) to head (ccd2307).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11180   +/-   ##
=======================================
  Coverage   90.91%   90.91%           
=======================================
  Files         499      499           
  Lines       50809    50809           
  Branches     8369     8371    +2     
=======================================
  Hits        46195    46195           
  Misses       4599     4599           
  Partials       15       15           
Flag Coverage Δ
unittest 90.91% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...lugin/src/rules/consistent-indexed-object-style.ts 99.31% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean 🔥

@JoshuaKGoldberg JoshuaKGoldberg merged commit 98c5c4c into typescript-eslint:main May 12, 2025
57 checks passed
@ronami ronami deleted the consistent-object-style-ts-mapped-type-no-annotation branch May 12, 2025 20:38
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request May 17, 2025
| datasource | package                          | from   | to     |
| ---------- | -------------------------------- | ------ | ------ |
| npm        | @typescript-eslint/eslint-plugin | 8.31.0 | 8.32.1 |
| npm        | @typescript-eslint/parser        | 8.31.0 | 8.32.1 |


## [v8.32.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8321-2025-05-12)

##### 🩹 Fixes

-   **eslint-plugin:** \[consistent-indexed-object-style] check for indirect circular types in aliased mapped types ([#11177](typescript-eslint/typescript-eslint#11177))
-   **eslint-plugin:** \[consistent-indexed-object-style] adjust auto-fixer to generate valid syntax for `TSMappedType` with no type annotation ([#11180](typescript-eslint/typescript-eslint#11180))
-   **eslint-plugin:** \[no-deprecated] support computed member access ([#10867](typescript-eslint/typescript-eslint#10867))
-   **eslint-plugin:** \[no-unnecessary-type-conversion] shouldn't have fixable property ([#11194](typescript-eslint/typescript-eslint#11194))

##### ❤️ Thank You

-   Azat S. [@azat-io](https://github.com/azat-io)
-   Dima Barabash [@dbarabashh](https://github.com/dbarabashh)
-   Ronen Amiel

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.


## [v8.32.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8320-2025-05-05)

##### 🚀 Features

-   **eslint-plugin:** \[only-throw-error] add option `allowRethrowing` ([#11075](typescript-eslint/typescript-eslint#11075))
-   **eslint-plugin:** \[no-unnecessary-type-conversion] add rule ([#10182](typescript-eslint/typescript-eslint#10182))

##### 🩹 Fixes

-   **eslint-plugin:** \[prefer-nullish-coalescing] fix parenthesization bug in suggestion ([#11098](typescript-eslint/typescript-eslint#11098))
-   **eslint-plugin:** \[unified-signatures] exempt `this` from optional parameter overload check ([#11005](typescript-eslint/typescript-eslint#11005))
-   **eslint-plugin:** \[no-unnecessary-type-parameters] should parenthesize type in suggestion fixer if necessary ([#10907](typescript-eslint/typescript-eslint#10907))

##### ❤️ Thank You

-   Andy Edwards
-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)
-   mdm317
-   Sasha Kondrashov
-   Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.


## [v8.31.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8311-2025-04-28)

##### 🩹 Fixes

-   **eslint-plugin:** \[no-unnecessary-condition] downgrade fix to suggestion ([#11081](typescript-eslint/typescript-eslint#11081))

##### ❤️ Thank You

-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants