Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(typescript-eslint): correct naming of import of typescript-eslint in test #11193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kirkwaiblinger
Copy link
Member

PR Checklist

Overview

Just a quick rename. The test code is a little confusing because it refers to plugin.configs, but we canonically would refer to this as tseslint.configs, and it is not equal to tseslint.plugin.configs.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


πŸ™ Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented May 8, 2025

βœ… Deploy Preview for typescript-eslint ready!

Name Link
πŸ”¨ Latest commit 90ac2e4
πŸ” Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/681d00822b047800080ad917
😎 Deploy Preview https://deploy-preview-11193--typescript-eslint.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 92 (πŸ”΄ down 7 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@kirkwaiblinger kirkwaiblinger changed the title chore(typescript-eslint): rename import of typescript-eslint chore(typescript-eslint): rename import of typescript-eslint in test May 8, 2025
Copy link

nx-cloud bot commented May 8, 2025

View your CI Pipeline Execution β†— for commit 90ac2e4.

Command Status Duration Result
nx typecheck ast-spec βœ… Succeeded <1s View β†—
nx run-many --target=build --exclude website --... βœ… Succeeded 2s View β†—
nx run-many --target=clean βœ… Succeeded 10s View β†—

☁️ Nx Cloud last updated this comment at 2025-05-09 07:27:52 UTC

@kirkwaiblinger kirkwaiblinger changed the title chore(typescript-eslint): rename import of typescript-eslint in test chore(typescript-eslint): correct naming of import of typescript-eslint in test May 8, 2025
Copy link
Member

@ronami ronami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸš€πŸš€ Nice! That aligns it to the other similar import in

@ronami ronami added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label May 9, 2025
@kirkwaiblinger kirkwaiblinger merged commit e57126a into typescript-eslint:main May 9, 2025
64 of 65 checks passed
@kirkwaiblinger kirkwaiblinger deleted the plugin-to-tseslint branch May 9, 2025 08:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants