Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(eslint-plugin): switch auto-generated test cases to hand-written in no-base-to-string.test.ts #11273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 16, 2025
Merged

chore(eslint-plugin): switch auto-generated test cases to hand-written in no-base-to-string.test.ts #11273

merged 4 commits into from
Jun 16, 2025
+63 −114

Conversation

nayounsang
Copy link
Contributor

@nayounsang nayounsang commented Jun 5, 2025 •
edited
Loading

PR Checklist

Overview

  • Change dynamic test cases using spread and map to hand-written ones
  • Specify existing recurring cases through comments

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @nayounsang!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nayounsang nayounsang marked this pull request as draft June 5, 2025 09:08
@netlify Netlify
Copy link

netlify bot commented Jun 5, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 7b41d4d
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68501ceb4870bb000998a59a
😎 Deploy Preview https://deploy-preview-11273--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 97 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (🟢 up 2 from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 5, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 7b41d4d.

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 8s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 15s View ↗
nx run-many -t lint ✅ Succeeded 13s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded <1s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded <1s View ↗
nx run integration-tests:test ✅ Succeeded <1s View ↗
nx run types:build ✅ Succeeded 9s View ↗
nx run generate-configs ✅ Succeeded 13s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-06-16 13:43:36 UTC

nayounsang
nayounsang commented Jun 5, 2025
View reviewed changes
packages/eslint-plugin/tests/rules/no-base-to-string.test.ts Outdated
"false + '';",
"false + 'text';",
'false + true;',
'false + false;',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

'false + true;',
'false + false;',
'true + true;',
'true + false;',

In my opinion, it would be neater to leave only one of these.

nayounsang
nayounsang commented Jun 5, 2025
View reviewed changes
Copy link
Contributor Author

@nayounsang nayounsang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I guess I can remove duplicate or unnecessary test cases now that I've changed to hand-written ones, but there are more than I thought and it's confusing me.
Let's go through this step by step with me. Excuse me, but I need to ask for your help!

@nayounsang nayounsang changed the title chore(eslint-plugin): switch auto-generated test cases to hand-written chore(eslint-plugin): switch auto-generated test cases to hand-written in no-base-to-string.test.ts Jun 5, 2025
@nayounsang nayounsang marked this pull request as ready for review June 5, 2025 09:24
nayounsang
nayounsang commented Jun 5, 2025
View reviewed changes
packages/eslint-plugin/tests/rules/no-base-to-string.test.ts
"`${__dirname === 'foobar'}`;",
'`${{}.constructor()}`;',
'`${() => {}}`;',
'`${function () {}}`;',

// operator + +=
Copy link
Contributor Author

@nayounsang nayounsang Jun 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many of the test cases in the operator + section are essentially duplicates that only differ in operand order. We could consider reducing them by half.
related to this comment: #11273 (comment)

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Jun 9, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Same with #11275 (review), do you want to make those removals @nayounsang?

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jun 9, 2025
@nayounsang
Copy link
Contributor Author

@JoshuaKGoldberg
Yes, I'll try to fix the things I mentioned in my self-review! Please wait a moment, I'll mention it again once I commit.

@codecov Codecov
Copy link

codecov bot commented Jun 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.84%. Comparing base (f9d4d10) to head (7b41d4d).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11273   +/-   ##
=======================================
  Coverage   90.84%   90.84%           
=======================================
  Files         501      501           
  Lines       50911    50911           
  Branches     8383     8383           
=======================================
  Hits        46248    46248           
  Misses       4648     4648           
  Partials       15       15
Flag Coverage Δ
unittest 90.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nayounsang
Copy link
Contributor Author

@JoshuaKGoldberg
I removed duplicate test cases for operator + +=: cases where the order is simply changed, cases where the same thing is added.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 3a8369d into typescript-eslint:main Jun 16, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: [no-base-to-string.test.ts] Switch auto-generated test cases to hand-written
2 participants
@nayounsang @JoshuaKGoldberg