Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(typescript-estree): align constructor literal with eslint #11299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 16, 2025
Merged

fix(typescript-estree): align constructor literal with eslint #11299

merged 3 commits into from
Jun 16, 2025
+795 −8

Conversation

ntdiary
Copy link
Contributor

@ntdiary ntdiary commented Jun 12, 2025 •
edited
Loading

PR Checklist

Overview

cases:

// Literal
class A {
  "constructor"() { }
}

// Identifier
class B {
  constructor() { }
}

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ntdiary!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jun 12, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit f6d3167
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/684fd4b6a93ae40008f99f88
😎 Deploy Preview https://deploy-preview-11299--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 12, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit f6d3167.

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 4s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 2s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 18s View ↗
nx run-many -t lint ✅ Succeeded 14s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 6s View ↗
nx run generate-configs ✅ Succeeded 7s View ↗
nx run types:build ✅ Succeeded 1s View ↗
nx run integration-tests:test ✅ Succeeded <1s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-06-16 08:35:38 UTC

@codecov Codecov
Copy link

codecov bot commented Jun 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 90.84%. Comparing base (af94f16) to head (f6d3167).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/typescript-estree/src/convert.ts 0.00% 18 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11299      +/-   ##
==========================================
- Coverage   90.85%   90.84%   -0.02%     
==========================================
  Files         501      501              
  Lines       50901    50911      +10     
  Branches     8383     8383              
==========================================
  Hits        46248    46248              
- Misses       4638     4648      +10     
  Partials       15       15
Flag Coverage Δ
unittest 90.84% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/typescript-estree/src/convert.ts 30.27% <0.00%> (-0.10%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ntdiary ntdiary marked this pull request as ready for review June 13, 2025 01:03
nayounsang
nayounsang reviewed Jun 13, 2025
View reviewed changes
bradzacher
bradzacher requested changes Jun 16, 2025
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change itself LGTM -- RC for adding snapshot tests!

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Jun 16, 2025
bradzacher
bradzacher approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

images (4).jpeg

@bradzacher bradzacher merged commit c971881 into typescript-eslint:main Jun 16, 2025
62 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nayounsang nayounsang nayounsang left review comments

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
awaiting response Issues waiting for a reply from the OP or another party
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: key of constructor in class C { "constructor"() {} } should not be an Identifier
3 participants
@ntdiary @bradzacher @nayounsang