fix(eslint-plugin): [no-unused-vars] no is assigned a value but only used as a type error when it has a same name
#11322
Conversation
|
Thanks for the PR, @nayounsang! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
is assigned a value but only used as a type error when it has a same name type alias declaration exporteis assigned a value but only used as a type error when it has a same name
|
View your CI Pipeline Execution ↗ for commit 2f474b3.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (88.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #11322 +/- ##
=======================================
Coverage 90.84% 90.84%
=======================================
Files 501 501
Lines 50911 50932 +21
Branches 8383 8391 +8
=======================================
+ Hits 46248 46269 +21
Misses 4648 4648
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| function isSafeUnusedExportCondition(variable: ScopeVariable): boolean { | ||
| if (variable instanceof ESLintScopeVariable) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
need advice
I don't know why this condition is necessary. Can't the arg type of isExported, isMergableExported be used as Variable?
Actually, it is used as Variable only.
| @@ -465,7 +495,12 @@ function isExported(variable: ScopeVariable): boolean { | |||
| } | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | |||
| return node.parent!.type.startsWith('Export'); | |||
| const isExportedFlag = node.parent!.type.startsWith('Export'); | |||
There was a problem hiding this comment.
need advice
Is there a reason why didn't use optional chaining before?
PR Checklist
is assigned a value but only used as a typeerror when it has a same name type alias declaration exported #10658Overview
Strict checks on exports with same type and variable name
isTypeVariable && isValueVariable.ClassName,TSEnumName,TSModuleName,ImportBindingandargumentsalso have same characteristicsPerform additional validating for abnormal cases
def.node.type !== AST_NODE_TYPES.TSTypeAliasDeclarationAdd test cases