Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(typescript-estree): ensure the token type of the property name is Identifier #11329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(typescript-estree): ensure the token type of the property name is Identifier #11329

wants to merge 1 commit into from

Conversation

ntdiary
Copy link
Contributor

@ntdiary ntdiary commented Jun 22, 2025

PR Checklist

Overview

I've gone with option 1 in the comments for now, if any regressions come up later, we can discuss them or try the other option if needed. :)

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ntdiary!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jun 22, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 274dd01
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/685789f845200a00089dbb52
😎 Deploy Preview https://deploy-preview-11329--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 22, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 274dd01.

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m View ↗
nx run-many -t typecheck ✅ Succeeded 1m 57s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 18s View ↗
nx run-many -t lint ✅ Succeeded 10s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 6s View ↗
nx run types:build ✅ Succeeded 1s View ↗
nx run generate-configs ✅ Succeeded 5s View ↗
nx run integration-tests:test ✅ Succeeded <1s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-06-22 04:54:03 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: The token type of if in the 262 IdentifierName production should be Identifier instead of Keyword
1 participant
@ntdiary