fix(eslint-plugin): [no-floating-promises] allowForKnownSafeCalls now supports function names (fixes #11423) #11430
+43
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… option Add test cases to verify that function name-based allowForKnownSafeCalls configuration works correctly for locally defined async functions.
…tion names (typescript-eslint#11423) The allowForKnownSafeCalls option was only checking type-based matching and not value-based matching, causing function name specifications like ["myAsyncFunction"] to be ignored. Now properly checks both value and type matching using valueMatchesSomeSpecifier.
- Remove skipValidation from allowForKnownSafeCalls example - Update test snapshots after fixing function name matching
Contributor
|
Thanks for the PR, @976520! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit ff2e5cd
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11430 +/- ##
==========================================
+ Coverage 90.87% 90.91% +0.03%
==========================================
Files 505 505
Lines 51117 51163 +46
Branches 8415 8428 +13
==========================================
+ Hits 46455 46516 +61
+ Misses 4648 4634 -14
+ Partials 14 13 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
JoshuaKGoldberg
previously approved these changes
Sep 3, 2025
Member
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
LGTM! Just one suggestion for a naming update, nothing in core logic or tests. Happy to just apply this change before our next release. Cheers! ❤️
ArnaudBarre
added a commit
to ArnaudBarre/tsl
that referenced
this pull request
Sep 10, 2025
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Sep 10, 2025
| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.42.0 | 8.43.0 | | npm | @typescript-eslint/parser | 8.42.0 | 8.43.0 | ## [v8.43.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8430-2025-09-08) ##### 🚀 Features - **typescript-estree:** disallow empty type parameter/argument lists ([#11563](typescript-eslint/typescript-eslint#11563)) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-return-this-type] don't report an error when returning a union type that includes a classType ([#11432](typescript-eslint/typescript-eslint#11432)) - **eslint-plugin:** \[no-deprecated] should report deprecated exports and reexports ([#11359](typescript-eslint/typescript-eslint#11359)) - **eslint-plugin:** \[no-floating-promises] allowForKnownSafeCalls now supports function names ([#11423](typescript-eslint/typescript-eslint#11423), [#11430](typescript-eslint/typescript-eslint#11430)) - **eslint-plugin:** \[consistent-type-exports] fix declaration shadowing ([#11457](typescript-eslint/typescript-eslint#11457)) - **eslint-plugin:** \[no-unnecessary-type-conversion] only report \~\~ on integer literal types ([#11517](typescript-eslint/typescript-eslint#11517)) - **scope-manager:** exclude Program from DefinitionBase node types ([#11469](typescript-eslint/typescript-eslint#11469)) - **eslint-plugin:** \[no-non-null-assertion] do not suggest optional chain on LHS of assignment ([#11489](typescript-eslint/typescript-eslint#11489)) - **type-utils:** add union type support to TypeOrValueSpecifier ([#11526](typescript-eslint/typescript-eslint#11526)) ##### ❤️ Thank You - Dima [@dbarabashh](https://github.com/dbarabashh) - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - mdm317 - tao - Victor Genaev [@mainframev](https://github.com/mainframev) - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) - 민감자(Minji Kim) [@mouse0429](https://github.com/mouse0429) - 송재욱 You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
The allowForKnownSafeCalls option was only checking type-based matching using typeMatchesSomeSpecifier and completely ignoring value-based (function name) matching. This caused configurations like
["randomAsyncFunction"]to be ignored, even though the documentation indicated they should work 💖f4d5dae
8c1cc90
af92aea