Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(eslint-plugin): [no-floating-promises] remove excess parentheses in suggestions #11487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2025
Merged

fix(eslint-plugin): [no-floating-promises] remove excess parentheses in suggestions #11487

merged 1 commit into from
Oct 1, 2025
+26 −25

Conversation

@kirkwaiblinger
Copy link
Member

@kirkwaiblinger kirkwaiblinger commented Aug 15, 2025 •
edited
Loading

PR Checklist

Overview

Stacked on #11479

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Aug 15, 2025

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Aug 15, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 6169380
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68db6069e1d81d000806f3f1
😎 Deploy Preview https://deploy-preview-11487--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (🟢 up 20 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link

nx-cloud bot commented Aug 15, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 6169380

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 10s View ↗
nx run-many -t lint ✅ Succeeded 3m 24s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 3s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 3s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx run integration-tests:test ✅ Succeeded 3s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx run generate-configs ✅ Succeeded 8s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-09-30 04:57:54 UTC

@codecov
Copy link

codecov bot commented Aug 15, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.93%. Comparing base (db09a7d) to head (6169380).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11487   +/-   ##
=======================================
  Coverage   90.93%   90.93%           
=======================================
  Files         506      506           
  Lines       51397    51392    -5     
  Branches     8484     8492    +8     
=======================================
- Hits        46738    46735    -3     
+ Misses       4646     4644    -2     
  Partials       13       13
Flag Coverage Δ
unittest 90.93% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...es/eslint-plugin/src/rules/no-floating-promises.ts 98.40% <100.00%> (-0.03%) ⬇️
...es/eslint-plugin/src/util/getOperatorPrecedence.ts 62.17% <ø> (+0.74%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kirkwaiblinger kirkwaiblinger marked this pull request as ready for review August 15, 2025 18:59
@kirkwaiblinger kirkwaiblinger marked this pull request as draft August 15, 2025 18:59
@kirkwaiblinger kirkwaiblinger changed the title fix(eslint-plugin): [no-floating-promises] remove excessive parentheses in suggestions fix(eslint-plugin): [no-floating-promises] remove excess parentheses in suggestions Aug 15, 2025
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Sep 25, 2025
Closed
4 tasks
@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Sep 29, 2025

@kirkwaiblinger is this ready now?

@kirkwaiblinger kirkwaiblinger force-pushed the fix-excessive-parentheses branch from 771f175 to 6169380 Compare September 30, 2025 04:45
@kirkwaiblinger kirkwaiblinger marked this pull request as ready for review September 30, 2025 04:46
@kirkwaiblinger
Copy link
Member Author

kirkwaiblinger commented Sep 30, 2025

@kirkwaiblinger is this ready now?

@JoshuaKGoldberg Redid it since it was pretty stale! Should be ready now

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Sep 30, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🚀

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 30, 2025
ronami
ronami approved these changes Sep 30, 2025
View reviewed changes
Copy link
Member

@ronami ronami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@JoshuaKGoldberg JoshuaKGoldberg merged commit d447248 into typescript-eslint:main Oct 1, 2025
71 of 72 checks passed
@kirkwaiblinger kirkwaiblinger deleted the fix-excessive-parentheses branch October 1, 2025 14:58
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Oct 8, 2025
@renovate
Update typescript-eslint monorepo to v8.46.0
a20d540 
| datasource | package                          | from   | to     |
| ---------- | -------------------------------- | ------ | ------ |
| npm        | @typescript-eslint/eslint-plugin | 8.45.0 | 8.46.0 |
| npm        | @typescript-eslint/parser        | 8.45.0 | 8.46.0 |


## [v8.46.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8460-2025-10-06)

##### 🚀 Features

- **eslint-plugin:** \[no-unsafe-member-access] add allowOptionalChaining option ([#11659](typescript-eslint/typescript-eslint#11659))
- **rule-schema-to-typescript-types:** clean up and make public ([#11633](typescript-eslint/typescript-eslint#11633))

##### 🩹 Fixes

- **eslint-plugin:** \[prefer-readonly-parameter-types] ignore tagged primitives ([#11660](typescript-eslint/typescript-eslint#11660))
- **typescript-estree:** forbid abstract method and accessor to have implementation ([#11657](typescript-eslint/typescript-eslint#11657))
- **eslint-plugin:** removed error type previously deprecated ([#11674](typescript-eslint/typescript-eslint#11674))
- **eslint-plugin:** \[no-deprecated] ignore deprecated `export import`s ([#11603](typescript-eslint/typescript-eslint#11603))
- **eslint-plugin:** \[unbound-method] improve wording around `this: void` and binding ([#11634](typescript-eslint/typescript-eslint#11634))
- **rule-tester:** deprecate TestCaseError#type and LintMessage#nodeType ([#11628](typescript-eslint/typescript-eslint#11628))
- **eslint-plugin:** \[no-floating-promises] remove excess parentheses in suggestions ([#11487](typescript-eslint/typescript-eslint#11487))

##### ❤️ Thank You

- fisker Cheung [@fisker](https://github.com/fisker)
- Josh Goldberg ✨
- Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)
- Mark de Dios [@peanutenthusiast](https://github.com/peanutenthusiast)
- Richard Torres [@richardtorres314](https://github.com/richardtorres314)
- Victor Genaev [@mainframev](https://github.com/mainframev)

You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Oct 8, 2025
@renovate
Update typescript-eslint monorepo to v8.46.0
9ea54a6 
| datasource | package                          | from   | to     |
| ---------- | -------------------------------- | ------ | ------ |
| npm        | @typescript-eslint/eslint-plugin | 8.45.0 | 8.46.0 |
| npm        | @typescript-eslint/parser        | 8.45.0 | 8.46.0 |


## [v8.46.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8460-2025-10-06)

##### 🚀 Features

- **eslint-plugin:** \[no-unsafe-member-access] add allowOptionalChaining option ([#11659](typescript-eslint/typescript-eslint#11659))
- **rule-schema-to-typescript-types:** clean up and make public ([#11633](typescript-eslint/typescript-eslint#11633))

##### 🩹 Fixes

- **eslint-plugin:** \[prefer-readonly-parameter-types] ignore tagged primitives ([#11660](typescript-eslint/typescript-eslint#11660))
- **typescript-estree:** forbid abstract method and accessor to have implementation ([#11657](typescript-eslint/typescript-eslint#11657))
- **eslint-plugin:** removed error type previously deprecated ([#11674](typescript-eslint/typescript-eslint#11674))
- **eslint-plugin:** \[no-deprecated] ignore deprecated `export import`s ([#11603](typescript-eslint/typescript-eslint#11603))
- **eslint-plugin:** \[unbound-method] improve wording around `this: void` and binding ([#11634](typescript-eslint/typescript-eslint#11634))
- **rule-tester:** deprecate TestCaseError#type and LintMessage#nodeType ([#11628](typescript-eslint/typescript-eslint#11628))
- **eslint-plugin:** \[no-floating-promises] remove excess parentheses in suggestions ([#11487](typescript-eslint/typescript-eslint#11487))

##### ❤️ Thank You

- fisker Cheung [@fisker](https://github.com/fisker)
- Josh Goldberg ✨
- Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)
- Mark de Dios [@peanutenthusiast](https://github.com/peanutenthusiast)
- Richard Torres [@richardtorres314](https://github.com/richardtorres314)
- Victor Genaev [@mainframev](https://github.com/mainframev)

You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
@fossabot fossabot bot mentioned this pull request Oct 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@ronami ronami ronami approved these changes

Assignees

No one assigned

Labels

1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: [no-floating-promises] adds extra parentheses to already-parenthesized expression

3 participants

@kirkwaiblinger @JoshuaKGoldberg @ronami