-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(eslint-plugin): [no-non-null-assertion] do not suggest optional chain on LHS of assignment #11489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JoshuaKGoldberg
merged 13 commits into
typescript-eslint:main
from
y-hsgw:fix/no-non-null-assertion
Sep 3, 2025
+37
−1
Merged
fix(eslint-plugin): [no-non-null-assertion] do not suggest optional chain on LHS of assignment #11489
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
a0da01b
fix: disable suggestion when non-null assertion is used as an assignee
y-hsgw f0feb9e
test: add tests
y-hsgw 9aaa525
chore: fix lint errors
y-hsgw a37427a
Merge branch 'main' of https://github.com/y-hsgw/typescript-eslint in…
y-hsgw ebc94de
Merge branch 'main' into fix/no-non-null-assertion
y-hsgw d2e2ef6
Merge branch 'main' into fix/no-non-null-assertion
y-hsgw 3248823
test: remove noFormat
y-hsgw dd0bcd1
test: fix test output
y-hsgw 2ae4c82
chore: fix lint
y-hsgw f04d699
Merge branch 'main' into fix/no-non-null-assertion
y-hsgw 0ad658a
test: fix test output
y-hsgw cf7965b
test: fix test output
y-hsgw 0b0b179
Merge branch 'main' into fix/no-non-null-assertion
kirkwaiblinger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.