Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(typescript-estree): forbid class property with name constructor #11590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 22, 2025
Merged

fix(typescript-estree): forbid class property with name constructor #11590

merged 2 commits into from
Sep 22, 2025

Conversation

@fisker
Copy link
Contributor

@fisker fisker commented Sep 10, 2025 •
edited
Loading

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Sep 10, 2025

Thanks for the PR, @fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Sep 10, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit c8686b8
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68c1f26f8a439c00088b94ef
😎 Deploy Preview https://deploy-preview-11590--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 90 (🟢 up 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link

nx-cloud bot commented Sep 10, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit c8686b8

Command Status Duration Result
nx run-many -t lint ✅ Succeeded 3m 21s View ↗
nx run-many -t typecheck ✅ Succeeded 1m 52s View ↗
nx run integration-tests:test ✅ Succeeded 6s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 3s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx run types:build ✅ Succeeded 9s View ↗
nx run generate-configs ✅ Succeeded 12s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 2s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-09-10 22:01:24 UTC

@fisker fisker marked this pull request as ready for review September 10, 2025 21:52
@codecov
Copy link

codecov bot commented Sep 10, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.89%. Comparing base (95c7287) to head (c8686b8).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
packages/typescript-estree/src/convert.ts 11.11% 8 Missing ⚠️

❌ Your patch status has failed because the patch coverage (11.11%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11590      +/-   ##
==========================================
- Coverage   90.90%   90.89%   -0.02%     
==========================================
  Files         505      505              
  Lines       51208    51217       +9     
  Branches     8441     8443       +2     
==========================================
+ Hits        46551    46552       +1     
- Misses       4644     4652       +8     
  Partials       13       13
Flag Coverage Δ
unittest 90.89% <11.11%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/typescript-estree/src/convert.ts 30.27% <11.11%> (-0.06%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kirkwaiblinger kirkwaiblinger added the AST PRs and Issues about the AST structure label Sep 10, 2025
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Sep 15, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks as always @fisker!

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 15, 2025
@JoshuaKGoldberg JoshuaKGoldberg merged commit fde540e into typescript-eslint:main Sep 22, 2025
63 of 64 checks passed
@fisker fisker deleted the constructor-property branch September 22, 2025 14:04
@chrisbbreuer chrisbbreuer mentioned this pull request Sep 22, 2025
Closed
@fossabot fossabot bot mentioned this pull request Sep 29, 2025
Merged
@chrisbbreuer chrisbbreuer mentioned this pull request Oct 4, 2025
Open
1 task
@fossabot fossabot bot mentioned this pull request Oct 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees

No one assigned

Labels

1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge AST PRs and Issues about the AST structure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhancement: Forbid class property with name constructor

3 participants

@fisker @JoshuaKGoldberg @kirkwaiblinger