Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(eslint-plugin): [no-base-to-string] make ignoredTypeNames match type names without generics #11597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2025
+42 −0
Merged

fix(eslint-plugin): [no-base-to-string] make ignoredTypeNames match type names without generics #11597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions packages/eslint-plugin/src/rules/no-base-to-string.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,13 @@ export type Options = [
},
];
export type MessageIds = 'baseArrayJoin' | 'baseToString';
const canHaveTypeParameters = (declaration: ts.Declaration) => {
return (
ts.isTypeAliasDeclaration(declaration) ||
ts.isInterfaceDeclaration(declaration) ||
ts.isClassDeclaration(declaration)
);
};

export default createRule<Options, MessageIds>({
name: 'no-base-to-string',
Expand Down Expand Up @@ -231,6 +238,17 @@ export default createRule<Options, MessageIds>({
return Usefulness.Always;
}

const symbol = type.aliasSymbol ?? type.getSymbol();
const decl = symbol?.getDeclarations()?.[0];
if (
decl &&
canHaveTypeParameters(decl) &&
decl.typeParameters &&
ignoredTypeNames.includes(symbol.name)
) {
return Usefulness.Always;
}

if (ignoredTypeNames.includes(getTypeName(checker, type))) {
return Usefulness.Always;
}
Expand Down
24 changes: 24 additions & 0 deletions packages/eslint-plugin/tests/rules/no-base-to-string.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,30 @@ String(foo);
`,
options: [{ ignoredTypeNames: ['Foo'] }],
},
{
code: `
interface MyError<T> {}
declare const error: MyError<number>;
error.toString();
`,
options: [{ ignoredTypeNames: ['MyError'] }],
},
{
code: `
type MyError<T> = {};
declare const error: MyError<number>;
error.toString();
`,
options: [{ ignoredTypeNames: ['MyError'] }],
},
{
code: `
class MyError<T> {}
declare const error: MyError<number>;
error.toString();
`,
options: [{ ignoredTypeNames: ['MyError'] }],
},
`
function String(value) {
return value;
Expand Down
Loading