fix(eslint-plugin): [no-unsafe-enum-comparison] support unions of literals #11599
+98
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR, @kirkwaiblinger! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit e74b701
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Please upload reports for the commit e74b701 to get more accurate results. Additional details and impacted files@@ Coverage Diff @@
## main #11599 +/- ##
=======================================
Coverage 90.90% 90.90%
=======================================
Files 505 505
Lines 51208 51218 +10
Branches 8441 8444 +3
=======================================
+ Hits 46551 46561 +10
Misses 4644 4644
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Sep 23, 2025
| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.44.0 | 8.44.1 | | npm | @typescript-eslint/parser | 8.44.0 | 8.44.1 | ## [v8.44.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8441-2025-09-22) ##### 🩹 Fixes - **eslint-plugin:** \[await-thenable] should not report passing values to promise aggregators which may be a promise in an array literal ([#11611](typescript-eslint/typescript-eslint#11611)) - **eslint-plugin:** \[no-unsafe-enum-comparison] support unions of literals ([#11599](typescript-eslint/typescript-eslint#11599)) - **eslint-plugin:** \[no-base-to-string] make ignoredTypeNames match type names without generics ([#11597](typescript-eslint/typescript-eslint#11597)) ##### ❤️ Thank You - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - mdm317 - Ronen Amiel You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Sep 25, 2025
| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.44.0 | 8.44.1 | | npm | @typescript-eslint/parser | 8.44.0 | 8.44.1 | ## [v8.44.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8441-2025-09-22) ##### 🩹 Fixes - **eslint-plugin:** \[await-thenable] should not report passing values to promise aggregators which may be a promise in an array literal ([#11611](typescript-eslint/typescript-eslint#11611)) - **eslint-plugin:** \[no-unsafe-enum-comparison] support unions of literals ([#11599](typescript-eslint/typescript-eslint#11599)) - **eslint-plugin:** \[no-base-to-string] make ignoredTypeNames match type names without generics ([#11597](typescript-eslint/typescript-eslint#11597)) ##### ❤️ Thank You - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - mdm317 - Ronen Amiel You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Sep 26, 2025
| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.44.0 | 8.44.1 | | npm | @typescript-eslint/parser | 8.44.0 | 8.44.1 | ## [v8.44.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8441-2025-09-22) ##### 🩹 Fixes - **eslint-plugin:** \[await-thenable] should not report passing values to promise aggregators which may be a promise in an array literal ([#11611](typescript-eslint/typescript-eslint#11611)) - **eslint-plugin:** \[no-unsafe-enum-comparison] support unions of literals ([#11599](typescript-eslint/typescript-eslint#11599)) - **eslint-plugin:** \[no-base-to-string] make ignoredTypeNames match type names without generics ([#11597](typescript-eslint/typescript-eslint#11597)) ##### ❤️ Thank You - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - mdm317 - Ronen Amiel You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Sep 27, 2025
| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.44.0 | 8.44.1 | | npm | @typescript-eslint/parser | 8.44.0 | 8.44.1 | ## [v8.44.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8441-2025-09-22) ##### 🩹 Fixes - **eslint-plugin:** \[await-thenable] should not report passing values to promise aggregators which may be a promise in an array literal ([#11611](typescript-eslint/typescript-eslint#11611)) - **eslint-plugin:** \[no-unsafe-enum-comparison] support unions of literals ([#11599](typescript-eslint/typescript-eslint#11599)) - **eslint-plugin:** \[no-base-to-string] make ignoredTypeNames match type names without generics ([#11597](typescript-eslint/typescript-eslint#11597)) ##### ❤️ Thank You - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - mdm317 - Ronen Amiel You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
1 task
This was referenced Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
The problem was not about which type was the switch argument and which was the case, and more so about the fact that the rule didn't consider unions of number literals to be numbers (and ditto for strings).