fix(eslint-plugin): [no-deprecated] ignore deprecated `export import`s #11603

mainframev · 2025-09-15T12:38:59Z

PR Checklist

Addresses an existing open issue: fixes Bug: [no-deprecated] import = marked as deprecated at definition #11586
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

PR enhances the no-deprecated ESLint rule to better handle TSImportEqualsDeclaration, specifically cases like export import Bar = Foo;

…ImportEqualsDeclaration

typescript-eslint · 2025-09-15T12:39:02Z

Thanks for the PR, @mainframev!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2025-09-15T12:39:05Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`37c6ff7`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/68dd3e5b2db99d00082b1f81
😎 Deploy Preview	https://deploy-preview-11603--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 83 (🟢 up 5 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

nx-cloud · 2025-09-15T12:42:28Z

View your CI Pipeline Execution ↗ for commit 37c6ff7

Command	Status	Duration	Result
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 3s	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 12s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 7s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	3s	View ↗
`nx run types:build`	✅ Succeeded	5s	View ↗
`nx run integration-tests:test`	✅ Succeeded	4s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	2s	View ↗
`nx run generate-configs`	✅ Succeeded	9s	View ↗
`Additional runs (27)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2025-10-01 14:57:11 UTC

JoshuaKGoldberg

LGTM, thanks!

packages/eslint-plugin/src/rules/no-deprecated.ts

JoshuaKGoldberg

+1 to the test request

…n on TSImportEqualsDeclaration

codecov · 2025-10-01T14:57:24Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.95%. Comparing base (85d8dea) to head (37c6ff7).
⚠️ Report is 50 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11603      +/-   ##
==========================================
+ Coverage   90.92%   90.95%   +0.03%     
==========================================
  Files         506      506              
  Lines       51325    51435     +110     
  Branches     8469     8492      +23     
==========================================
+ Hits        46665    46785     +120     
+ Misses       4647     4637      -10     
  Partials       13       13

Flag	Coverage Δ
unittest	`90.95% <100.00%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
packages/eslint-plugin/src/rules/no-deprecated.ts	`97.16% <100.00%> (+0.01%)`	⬆️

... and 18 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg

💯 thanks!

@fisker

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.45.0 | 8.46.0 | | npm | @typescript-eslint/parser | 8.45.0 | 8.46.0 | ## [v8.46.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8460-2025-10-06) ##### 🚀 Features - **eslint-plugin:** \[no-unsafe-member-access] add allowOptionalChaining option ([#11659](typescript-eslint/typescript-eslint#11659)) - **rule-schema-to-typescript-types:** clean up and make public ([#11633](typescript-eslint/typescript-eslint#11633)) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-readonly-parameter-types] ignore tagged primitives ([#11660](typescript-eslint/typescript-eslint#11660)) - **typescript-estree:** forbid abstract method and accessor to have implementation ([#11657](typescript-eslint/typescript-eslint#11657)) - **eslint-plugin:** removed error type previously deprecated ([#11674](typescript-eslint/typescript-eslint#11674)) - **eslint-plugin:** \[no-deprecated] ignore deprecated `export import`s ([#11603](typescript-eslint/typescript-eslint#11603)) - **eslint-plugin:** \[unbound-method] improve wording around `this: void` and binding ([#11634](typescript-eslint/typescript-eslint#11634)) - **rule-tester:** deprecate TestCaseError#type and LintMessage#nodeType ([#11628](typescript-eslint/typescript-eslint#11628)) - **eslint-plugin:** \[no-floating-promises] remove excess parentheses in suggestions ([#11487](typescript-eslint/typescript-eslint#11487)) ##### ❤️ Thank You - fisker Cheung [@fisker](https://github.com/fisker) - Josh Goldberg ✨ - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - Mark de Dios [@peanutenthusiast](https://github.com/peanutenthusiast) - Richard Torres [@richardtorres314](https://github.com/richardtorres314) - Victor Genaev [@mainframev](https://github.com/mainframev) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

@fisker

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.45.0 | 8.46.0 | | npm | @typescript-eslint/parser | 8.45.0 | 8.46.0 | ## [v8.46.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8460-2025-10-06) ##### 🚀 Features - **eslint-plugin:** \[no-unsafe-member-access] add allowOptionalChaining option ([#11659](typescript-eslint/typescript-eslint#11659)) - **rule-schema-to-typescript-types:** clean up and make public ([#11633](typescript-eslint/typescript-eslint#11633)) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-readonly-parameter-types] ignore tagged primitives ([#11660](typescript-eslint/typescript-eslint#11660)) - **typescript-estree:** forbid abstract method and accessor to have implementation ([#11657](typescript-eslint/typescript-eslint#11657)) - **eslint-plugin:** removed error type previously deprecated ([#11674](typescript-eslint/typescript-eslint#11674)) - **eslint-plugin:** \[no-deprecated] ignore deprecated `export import`s ([#11603](typescript-eslint/typescript-eslint#11603)) - **eslint-plugin:** \[unbound-method] improve wording around `this: void` and binding ([#11634](typescript-eslint/typescript-eslint#11634)) - **rule-tester:** deprecate TestCaseError#type and LintMessage#nodeType ([#11628](typescript-eslint/typescript-eslint#11628)) - **eslint-plugin:** \[no-floating-promises] remove excess parentheses in suggestions ([#11487](typescript-eslint/typescript-eslint#11487)) ##### ❤️ Thank You - fisker Cheung [@fisker](https://github.com/fisker) - Josh Goldberg ✨ - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - Mark de Dios [@peanutenthusiast](https://github.com/peanutenthusiast) - Richard Torres [@richardtorres314](https://github.com/richardtorres314) - Victor Genaev [@mainframev](https://github.com/mainframev) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

fix(eslint-plugin): no-deprecated should not report deprecation on TS…

3e36eba

…ImportEqualsDeclaration

mainframev changed the title ~~fix(eslint-plugin): no-deprecated should not report deprecation on TS…~~ fix(eslint-plugin): [no-deprecated] should not report deprecation on TS… Sep 15, 2025

mainframev marked this pull request as ready for review September 15, 2025 15:23

JoshuaKGoldberg changed the title ~~fix(eslint-plugin): [no-deprecated] should not report deprecation on TS…~~ fix(eslint-plugin): [no-deprecated] ignore deprecated export imports Sep 15, 2025

JoshuaKGoldberg approved these changes Sep 15, 2025

View reviewed changes

JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 15, 2025

kirkwaiblinger reviewed Sep 16, 2025

View reviewed changes

packages/eslint-plugin/src/rules/no-deprecated.ts Show resolved Hide resolved

JoshuaKGoldberg added awaiting response Issues waiting for a reply from the OP or another party and removed 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labels Sep 22, 2025

JoshuaKGoldberg requested changes Sep 22, 2025

View reviewed changes

fixup! fix(eslint-plugin): no-deprecated should not report deprecatio…

37c6ff7

…n on TSImportEqualsDeclaration

mainframev requested review from JoshuaKGoldberg and kirkwaiblinger October 1, 2025 14:44

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Oct 1, 2025

JoshuaKGoldberg approved these changes Oct 3, 2025

View reviewed changes

JoshuaKGoldberg merged commit f8412ce into typescript-eslint:main Oct 3, 2025
63 of 64 checks passed

fossabot bot mentioned this pull request Oct 9, 2025

Bump @typescript-eslint/eslint-plugin from 8.44.1 to 8.46.0 fossas/fossa-action#220

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(eslint-plugin): [no-deprecated] ignore deprecated `export import`s #11603

fix(eslint-plugin): [no-deprecated] ignore deprecated `export import`s #11603

mainframev commented Sep 15, 2025

Uh oh!

typescript-eslint bot commented Sep 15, 2025

Uh oh!

netlify bot commented Sep 15, 2025 •

edited

Loading

Uh oh!

nx-cloud bot commented Sep 15, 2025 •

edited

Loading

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

codecov bot commented Oct 1, 2025 •

edited

Loading

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix(eslint-plugin): [no-deprecated] ignore deprecated export imports #11603

fix(eslint-plugin): [no-deprecated] ignore deprecated export imports #11603

Conversation

mainframev commented Sep 15, 2025

PR Checklist

Overview

Uh oh!

typescript-eslint bot commented Sep 15, 2025

Uh oh!

netlify bot commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

nx-cloud bot commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(eslint-plugin): [no-deprecated] ignore deprecated `export import`s #11603

fix(eslint-plugin): [no-deprecated] ignore deprecated `export import`s #11603

netlify bot commented Sep 15, 2025 •

edited

Loading

nx-cloud bot commented Sep 15, 2025 •

edited

Loading

codecov bot commented Oct 1, 2025 •

edited

Loading