Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(ast-spec): cleanup TSLiteralType #11624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 7, 2025
Merged

fix(ast-spec): cleanup TSLiteralType #11624

merged 4 commits into from
Oct 7, 2025

Conversation

@abrahamguo
Copy link
Contributor

@abrahamguo abrahamguo commented Sep 22, 2025

PR Checklist

Overview

From @bradzacher's proposal in #11587:

  • Remove UpdateExpression from the type
  • Refine the Literal union to just the valid literals
  • Refine the UnaryExpression to just the valid operators

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Sep 22, 2025

Thanks for the PR, @abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Sep 22, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4dd2118
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68d8469963283c00083dce19
😎 Deploy Preview https://deploy-preview-11624--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🟢 up 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link

nx-cloud bot commented Sep 22, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 4dd2118

Command Status Duration Result
nx run-many -t lint ✅ Succeeded 3m 14s View ↗
nx run-many -t typecheck ✅ Succeeded 1m 52s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 3s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 3s View ↗
nx run integration-tests:test ✅ Succeeded 4s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 1s View ↗
nx run types:build ✅ Succeeded 9s View ↗
nx run generate-configs ✅ Succeeded 11s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-09-27 20:25:30 UTC

@abrahamguo abrahamguo changed the title enhancement(ast): cleanup TSLiteralType fix(ast): cleanup TSLiteralType Sep 22, 2025
@abrahamguo abrahamguo changed the title fix(ast): cleanup TSLiteralType fix(ast-spec): cleanup TSLiteralType Sep 22, 2025
@abrahamguo abrahamguo changed the title fix(ast-spec): cleanup TSLiteralType fix(ast-spec): cleanup TSLiteralType Sep 22, 2025
JoshuaKGoldberg
JoshuaKGoldberg reviewed Sep 22, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented Sep 26, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.93%. Comparing base (c1f891d) to head (4dd2118).
⚠️ Report is 47 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11624   +/-   ##
=======================================
  Coverage   90.93%   90.93%           
=======================================
  Files         506      506           
  Lines       51370    51370           
  Branches     8476     8476           
=======================================
  Hits        46711    46711           
  Misses       4646     4646           
  Partials       13       13
Flag Coverage Δ
unittest 90.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 3, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 love it, thanks!

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 3, 2025
@github-actions github-actions bot removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 6, 2025
@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 6, 2025
bradzacher
bradzacher approved these changes Oct 7, 2025
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice -- thanks!

@bradzacher bradzacher merged commit 8b05208 into typescript-eslint:main Oct 7, 2025
65 checks passed
@chrisbbreuer chrisbbreuer mentioned this pull request Oct 13, 2025
Open
1 task
@fossabot fossabot bot mentioned this pull request Oct 14, 2025
Closed
This was referenced Oct 21, 2025
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@bradzacher bradzacher bradzacher approved these changes

Assignees

No one assigned

Labels

1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhancement(AST): Cleanup TSLiteralType

3 participants

@abrahamguo @JoshuaKGoldberg @bradzacher