Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: disable generating declaration maps #11627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2025
Merged

fix: disable generating declaration maps #11627

merged 1 commit into from
Sep 29, 2025

Conversation

@bluwy
Copy link
Contributor

@bluwy bluwy commented Sep 23, 2025 •
edited
Loading

PR Checklist

Overview

Disables generating .d.ts.map files when building packages.

NOTE: The issue isn't marked accepting prs, but the fix is really simple so I thought to submit it for now.

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Sep 23, 2025

Thanks for the PR, @bluwy!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Sep 23, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 18356f4
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68d202cc8b44090008fc7c96
😎 Deploy Preview https://deploy-preview-11627--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 97 (🟢 up 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link

nx-cloud bot commented Sep 23, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 18356f4

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 27s View ↗
nx run-many -t lint ✅ Succeeded 3m 12s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 14s View ↗
nx run types:build ✅ Succeeded 6s View ↗
nx run integration-tests:test ✅ Succeeded 48s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 20s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 10s View ↗
nx run generate-configs ✅ Succeeded 14s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-09-23 02:27:59 UTC

@bluwy bluwy changed the title build: disable generating declaration maps fix: disable generating declaration maps Sep 23, 2025
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Sep 25, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 thanks!

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 25, 2025
@JoshuaKGoldberg JoshuaKGoldberg merged commit 7eeb093 into typescript-eslint:main Sep 29, 2025
70 of 73 checks passed
@bluwy bluwy deleted the disable-declaration-map branch September 29, 2025 12:21
This was referenced Sep 29, 2025
Closed
Open
This was referenced Oct 6, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees

No one assigned

Labels

1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Published .d.ts.map files have sources that points to unpublished files

2 participants

@bluwy @JoshuaKGoldberg