Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(ast-spec): narrow ArrowFunctionExpression.generator to false #11636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2025
Merged

fix(ast-spec): narrow ArrowFunctionExpression.generator to false #11636

merged 1 commit into from
Sep 27, 2025

Conversation

@JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Sep 26, 2025

PR Checklist

Overview

Narrows it from the general boolean to false per discussion in the issue.

💖

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Sep 26, 2025

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Sep 26, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 96c5596
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68d6980f82364a0009788b14
😎 Deploy Preview https://deploy-preview-11636--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 6 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link

nx-cloud bot commented Sep 26, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 96c5596

Command Status Duration Result
nx run-many -t lint ✅ Succeeded 3m 10s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 13s View ↗
nx run types:build ✅ Succeeded 6s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 1s View ↗
nx run integration-tests:test ✅ Succeeded 3s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 5s View ↗
nx run generate-configs ✅ Succeeded 9s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 4s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-09-26 13:48:12 UTC

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review September 26, 2025 14:22
@bradzacher bradzacher merged commit c1f891d into typescript-eslint:main Sep 27, 2025
63 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the ast-arrow-function-expression-generator-false branch September 27, 2025 11:29
This was referenced Sep 29, 2025
Closed
Open
This was referenced Oct 6, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: ArrowFunctionExpression's generator property should always be false

2 participants

@JoshuaKGoldberg @bradzacher