Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(typescript-estree): forbid abstract modifier in object methods #11656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2025
Merged

fix(typescript-estree): forbid abstract modifier in object methods #11656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f898407
fix(typescript-estree): forbid `abstract` modifier in object methods
fisker Sep 28, 2025
7d22df7
Merge branch 'main'
JoshuaKGoldberg Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ages/ast-spec/src/expression/ObjectExpression/fixtures/_error_/abstract-method/fixture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
({abstract method(){}})
7 changes: 7 additions & 0 deletions ...ression/ObjectExpression/fixtures/_error_/abstract-method/snapshots/1-TSESTree-Error.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions ...expression/ObjectExpression/fixtures/_error_/abstract-method/snapshots/2-Babel-Error.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions ...ession/ObjectExpression/fixtures/_error_/abstract-method/snapshots/3-Alignment-Error.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 13 additions & 0 deletions packages/typescript-estree/src/check-modifiers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,5 +371,18 @@ export function checkModifiers(node: ts.Node): void {
);
}
}

// There are more cases in `checkGrammarObjectLiteralExpression` in TypeScript.
// We may add more validations for them here in the future.
if (
modifier.kind === SyntaxKind.AbstractKeyword &&
node.kind === SyntaxKind.MethodDeclaration &&
node.parent.kind === SyntaxKind.ObjectLiteralExpression
) {
throwError(
modifier,
`'${ts.tokenToString(modifier.kind)}' modifier cannot be used here.`,
);
}
}
}