feat(eslint-plugin): [no-unsafe-member-access] add allowOptionalChaining option #11659

JoshuaKGoldberg · 2025-09-29T11:22:23Z

PR Checklist

Addresses an existing open issue: fixes [no-unsafe-member-access] Add exception for optional chaining #2728
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

This was a little tricker than I'd hoped. The AST positions ChainExpressions as the parent of all MemberExpressions in the chain, rather than inline in the stack. This PR modifies the node checker to have a third State, State.Chained, to save for nodes.

This results in an edge case where if you have an optional property in the middle of a stack of any MemberExpressions (value.outer?.middle.inner), the rule reports twice. I don't think this is a very common use case that we need to optimize for.

💖

…ing option

typescript-eslint · 2025-09-29T11:22:27Z

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2025-09-29T11:22:30Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`a9df1da`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/68e3b0ca91bb0f00080cdc2b
😎 Deploy Preview	https://deploy-preview-11659--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 96 (🟢 up 18 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

nx-cloud · 2025-09-29T11:23:48Z

View your CI Pipeline Execution ↗ for commit a9df1da

Command	Status	Duration	Result
`nx test eslint-plugin --coverage=false`	✅ Succeeded	4m 56s	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 8s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 10s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	4s	View ↗
`nx run types:build`	✅ Succeeded	5s	View ↗
`nx run integration-tests:test`	✅ Succeeded	5s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	2s	View ↗
`nx run generate-configs`	✅ Succeeded	8s	View ↗
`Additional runs (29)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2025-10-06 12:18:26 UTC

codecov · 2025-09-29T14:37:09Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.74%. Comparing base (7f5fed7) to head (a9df1da).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #11659   +/-   ##
=======================================
  Coverage   90.74%   90.74%           
=======================================
  Files         516      516           
  Lines       51987    52013   +26     
  Branches     8588     8594    +6     
=======================================
+ Hits        47174    47200   +26     
  Misses       4799     4799           
  Partials       14       14

Flag	Coverage Δ
unittest	`90.74% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...eslint-plugin/src/rules/no-unsafe-member-access.ts	`100.00% <100.00%> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ronami

🚀

packages/eslint-plugin/docs/rules/no-unsafe-member-access.mdx

packages/eslint-plugin/src/rules/no-unsafe-member-access.ts

Co-authored-by: Ronen Amiel <[email protected]>

@fisker

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.45.0 | 8.46.0 | | npm | @typescript-eslint/parser | 8.45.0 | 8.46.0 | ## [v8.46.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8460-2025-10-06) ##### 🚀 Features - **eslint-plugin:** \[no-unsafe-member-access] add allowOptionalChaining option ([#11659](typescript-eslint/typescript-eslint#11659)) - **rule-schema-to-typescript-types:** clean up and make public ([#11633](typescript-eslint/typescript-eslint#11633)) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-readonly-parameter-types] ignore tagged primitives ([#11660](typescript-eslint/typescript-eslint#11660)) - **typescript-estree:** forbid abstract method and accessor to have implementation ([#11657](typescript-eslint/typescript-eslint#11657)) - **eslint-plugin:** removed error type previously deprecated ([#11674](typescript-eslint/typescript-eslint#11674)) - **eslint-plugin:** \[no-deprecated] ignore deprecated `export import`s ([#11603](typescript-eslint/typescript-eslint#11603)) - **eslint-plugin:** \[unbound-method] improve wording around `this: void` and binding ([#11634](typescript-eslint/typescript-eslint#11634)) - **rule-tester:** deprecate TestCaseError#type and LintMessage#nodeType ([#11628](typescript-eslint/typescript-eslint#11628)) - **eslint-plugin:** \[no-floating-promises] remove excess parentheses in suggestions ([#11487](typescript-eslint/typescript-eslint#11487)) ##### ❤️ Thank You - fisker Cheung [@fisker](https://github.com/fisker) - Josh Goldberg ✨ - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - Mark de Dios [@peanutenthusiast](https://github.com/peanutenthusiast) - Richard Torres [@richardtorres314](https://github.com/richardtorres314) - Victor Genaev [@mainframev](https://github.com/mainframev) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

@fisker

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.45.0 | 8.46.0 | | npm | @typescript-eslint/parser | 8.45.0 | 8.46.0 | ## [v8.46.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8460-2025-10-06) ##### 🚀 Features - **eslint-plugin:** \[no-unsafe-member-access] add allowOptionalChaining option ([#11659](typescript-eslint/typescript-eslint#11659)) - **rule-schema-to-typescript-types:** clean up and make public ([#11633](typescript-eslint/typescript-eslint#11633)) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-readonly-parameter-types] ignore tagged primitives ([#11660](typescript-eslint/typescript-eslint#11660)) - **typescript-estree:** forbid abstract method and accessor to have implementation ([#11657](typescript-eslint/typescript-eslint#11657)) - **eslint-plugin:** removed error type previously deprecated ([#11674](typescript-eslint/typescript-eslint#11674)) - **eslint-plugin:** \[no-deprecated] ignore deprecated `export import`s ([#11603](typescript-eslint/typescript-eslint#11603)) - **eslint-plugin:** \[unbound-method] improve wording around `this: void` and binding ([#11634](typescript-eslint/typescript-eslint#11634)) - **rule-tester:** deprecate TestCaseError#type and LintMessage#nodeType ([#11628](typescript-eslint/typescript-eslint#11628)) - **eslint-plugin:** \[no-floating-promises] remove excess parentheses in suggestions ([#11487](typescript-eslint/typescript-eslint#11487)) ##### ❤️ Thank You - fisker Cheung [@fisker](https://github.com/fisker) - Josh Goldberg ✨ - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - Mark de Dios [@peanutenthusiast](https://github.com/peanutenthusiast) - Richard Torres [@richardtorres314](https://github.com/richardtorres314) - Victor Genaev [@mainframev](https://github.com/mainframev) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

feat(eslint-plugin): [no-unsafe-member-access] add allowOptionalChain…

f76329a

…ing option

JoshuaKGoldberg added 3 commits September 29, 2025 07:50

Update rule schema snapshot

055dd59

Fix docs

afd687b

Add missing ts option; update snapshots

d723a38

JoshuaKGoldberg marked this pull request as ready for review September 29, 2025 15:00

ronami previously approved these changes Sep 30, 2025

View reviewed changes

packages/eslint-plugin/docs/rules/no-unsafe-member-access.mdx Outdated Show resolved Hide resolved

packages/eslint-plugin/src/rules/no-unsafe-member-access.ts Outdated Show resolved Hide resolved

ronami added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 30, 2025

ronami reviewed Sep 30, 2025

View reviewed changes

packages/eslint-plugin/src/rules/no-unsafe-member-access.ts Show resolved Hide resolved

JoshuaKGoldberg dismissed ronami’s stale review via 501a3c9 September 30, 2025 13:47

JoshuaKGoldberg and others added 4 commits September 30, 2025 09:47

Apply suggestions from code review

501a3c9

Co-authored-by: Ronen Amiel <[email protected]>

Added test for allowOptionalChaining without optional

7b9caae

yarn test -u

c45b786

Merge branch 'main'

a9df1da

JoshuaKGoldberg merged commit f083798 into typescript-eslint:main Oct 6, 2025
63 of 66 checks passed

chrisbbreuer mentioned this pull request Oct 6, 2025

chore(deps): update all non-major dependencies stacksjs/eslint-plugin#67

Open

1 task

fossabot bot mentioned this pull request Oct 9, 2025

Bump @typescript-eslint/eslint-plugin from 8.44.1 to 8.46.0 fossas/fossa-action#220

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(eslint-plugin): [no-unsafe-member-access] add allowOptionalChaining option #11659

feat(eslint-plugin): [no-unsafe-member-access] add allowOptionalChaining option #11659

JoshuaKGoldberg commented Sep 29, 2025

Uh oh!

typescript-eslint bot commented Sep 29, 2025

Uh oh!

netlify bot commented Sep 29, 2025 •

edited

Loading

Uh oh!

nx-cloud bot commented Sep 29, 2025 •

edited

Loading

Uh oh!

codecov bot commented Sep 29, 2025 •

edited

Loading

Uh oh!

ronami left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

feat(eslint-plugin): [no-unsafe-member-access] add allowOptionalChaining option #11659

feat(eslint-plugin): [no-unsafe-member-access] add allowOptionalChaining option #11659

Conversation

JoshuaKGoldberg commented Sep 29, 2025

PR Checklist

Overview

Uh oh!

typescript-eslint bot commented Sep 29, 2025

Uh oh!

netlify bot commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

nx-cloud bot commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ronami left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Sep 29, 2025 •

edited

Loading

nx-cloud bot commented Sep 29, 2025 •

edited

Loading

codecov bot commented Sep 29, 2025 •

edited

Loading