fix(eslint-plugin): [no-duplicate-enum-values] support signed numbers (#11722) #11723

undsoft · 2025-10-27T17:50:02Z

PR Checklist

Addresses an existing open issue: fixes Bug: [no-duplicate-enum-values] doesn't handle explicitly signed numbers #11722
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

no-duplicate-enum-values will now support:

signed numbers, such as: -1, -0, +1
and unary expressions with strings, e.g. -"1"

I decided not to do anything for NaN, because I don't want to open this 🥫🪱.

…ned numbers (typescript-eslint#11722)

typescript-eslint · 2025-10-27T17:50:06Z

Thanks for the PR, @undsoft!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2025-10-27T17:50:07Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`874e889`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/68ffb4141d760400088538c0
😎 Deploy Preview	https://deploy-preview-11723--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 97 Accessibility: 97 Best Practices: 100 SEO: 92 PWA: 80 View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

nx-cloud · 2025-10-27T17:51:37Z

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

_{To disable these notifications, a workspace admin can disable them in workspace settings.}

View your CI Pipeline Execution ↗ for commit 874e889

Command	Status	Duration	Result
`nx run integration-tests:test`	❌ Failed	53s	View ↗
`nx test eslint-plugin --coverage=false`	✅ Succeeded	4m 47s	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 11s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 11s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	4s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	1s	View ↗
`nx run types:build`	✅ Succeeded	5s	View ↗
`nx run generate-configs`	✅ Succeeded	7s	View ↗
`Additional runs (29)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2025-10-27 18:17:26 UTC

codecov · 2025-10-27T18:02:58Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.66%. Comparing base (55ca033) to head (874e889).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #11723   +/-   ##
=======================================
  Coverage   90.66%   90.66%           
=======================================
  Files         518      518           
  Lines       52415    52438   +23     
  Branches     8678     8684    +6     
=======================================
+ Hits        47521    47544   +23     
  Misses       4880     4880           
  Partials       14       14

Flag	Coverage Δ
unittest	`90.66% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...slint-plugin/src/rules/no-duplicate-enum-values.ts	`100.00% <100.00%> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ned numbers (typescript-eslint#11722)

JoshuaKGoldberg

Great! Confirmed that Object.is is actually needed for the case of 0 vs. -0. You gotta love floating point numbers... 👌 thanks!

@undsoft

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.46.1 | 8.46.3 | | npm | @typescript-eslint/parser | 8.46.1 | 8.46.3 | ## [v8.46.3](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8463-2025-11-03) ##### 🩹 Fixes - **eslint-plugin:** \[no-duplicate-enum-values] support signed numbers ([#11722](typescript-eslint/typescript-eslint#11722), [#11723](typescript-eslint/typescript-eslint#11723)) - **eslint-plugin:** \[no-misused-promises] expand union type to retrieve target property ([#11706](typescript-eslint/typescript-eslint#11706)) ##### ❤️ Thank You - Evgeny Stepanovych [@undsoft](https://github.com/undsoft) - tao You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ## [v8.46.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#11702](typescript-eslint/typescript-eslint#11702)) ##### ❤️ Thank You - mdm317 You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

@undsoft

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.46.1 | 8.46.3 | | npm | @typescript-eslint/parser | 8.46.1 | 8.46.3 | ## [v8.46.3](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8463-2025-11-03) ##### 🩹 Fixes - **eslint-plugin:** \[no-duplicate-enum-values] support signed numbers ([#11722](typescript-eslint/typescript-eslint#11722), [#11723](typescript-eslint/typescript-eslint#11723)) - **eslint-plugin:** \[no-misused-promises] expand union type to retrieve target property ([#11706](typescript-eslint/typescript-eslint#11706)) ##### ❤️ Thank You - Evgeny Stepanovych [@undsoft](https://github.com/undsoft) - tao You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ## [v8.46.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#11702](typescript-eslint/typescript-eslint#11702)) ##### ❤️ Thank You - mdm317 You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

undsoft added 2 commits October 27, 2025 18:43

fix(eslint-plugin): [no-duplicate-enum-values] support explicitly sig…

5c0f387

…ned numbers (typescript-eslint#11722)

fix(eslint-plugin): [no-duplicate-enum-values] support explicitly sig…

7f34b9b

…ned numbers (typescript-eslint#11722)

undsoft changed the title ~~Signed enum numbers~~ fix(eslint-plugin): [no-duplicate-enum-values] support signed numbers (#11722) Oct 27, 2025

fix(eslint-plugin): [no-duplicate-enum-values] support explicitly sig…

874e889

…ned numbers (typescript-eslint#11722)

JoshuaKGoldberg approved these changes Nov 3, 2025

View reviewed changes

JoshuaKGoldberg merged commit 26a9f94 into typescript-eslint:main Nov 3, 2025
68 of 69 checks passed

chrisbbreuer mentioned this pull request Nov 3, 2025

chore(deps): update all non-major dependencies stacksjs/eslint-plugin#67

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(eslint-plugin): [no-duplicate-enum-values] support signed numbers (#11722) #11723

fix(eslint-plugin): [no-duplicate-enum-values] support signed numbers (#11722) #11723

undsoft commented Oct 27, 2025 •

edited by JoshuaKGoldberg

Loading

Uh oh!

typescript-eslint bot commented Oct 27, 2025

Uh oh!

netlify bot commented Oct 27, 2025 •

edited

Loading

Uh oh!

nx-cloud bot commented Oct 27, 2025 •

edited

Loading

Uh oh!

codecov bot commented Oct 27, 2025 •

edited

Loading

Uh oh!

JoshuaKGoldberg left a comment •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

fix(eslint-plugin): [no-duplicate-enum-values] support signed numbers (#11722) #11723

fix(eslint-plugin): [no-duplicate-enum-values] support signed numbers (#11722) #11723

Conversation

undsoft commented Oct 27, 2025 • edited by JoshuaKGoldberg Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslint bot commented Oct 27, 2025

Uh oh!

netlify bot commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

nx-cloud bot commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 Nx Cloud AI Fix Eligible

Uh oh!

codecov bot commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JoshuaKGoldberg left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

undsoft commented Oct 27, 2025 •

edited by JoshuaKGoldberg

Loading

netlify bot commented Oct 27, 2025 •

edited

Loading

nx-cloud bot commented Oct 27, 2025 •

edited

Loading

codecov bot commented Oct 27, 2025 •

edited

Loading

JoshuaKGoldberg left a comment •

edited

Loading