Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: explore switching two test file to VFS #11853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
ntdiary wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

chore: explore switching two test file to VFS #11853

ntdiary wants to merge 4 commits into from
+276 −23

Conversation

@ntdiary
Copy link
Contributor

@ntdiary ntdiary commented Dec 17, 2025 •
edited
Loading

PR Checklist

Overview

test files: consistent-type-exports.test.ts, no-deprecated.test.ts

Key code changes

  1. Within a test file, use tagged template to setup common fixture.
  2. Add an internal sys field to the parser. This is a ts.System instance required by both ts.createWatchCompilerHost and tsserver.server.ProjectService.
  3. Add a host field to the ParserServicesWithTypeInformation, which is required as a param by ts.resolveModuleName(in consistent-type-exports.ts).

Execution flow

  1. Call fixture tag function to setup the common fixture and return a sys instance.
  2. createRuleTesterWithTypes will pass sys to the parser and return the ruleTester instance.
  3. ruleTester will call sys.writeFile to write the code to VFS before linter.verify (in runRuleForItem)

💖

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Dec 17, 2025

Thanks for the PR, @ntdiary!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Dec 17, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4daa0b7
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/69426e4ff1c319000817fc7d
😎 Deploy Preview https://deploy-preview-11853--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 97 (🟢 up 18 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link

nx-cloud bot commented Dec 17, 2025 •
edited
Loading

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.

View your CI Pipeline Execution ↗ for commit 4daa0b7

Command Status Duration Result
nx test eslint-plugin ❌ Failed 6m 30s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 15s View ↗
nx run types:build ✅ Succeeded 2s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 11s View ↗
nx run integration-tests:test ✅ Succeeded 7s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 19s View ↗
nx run generate-configs ✅ Succeeded 8s View ↗
nx run-many --target=build --parallel --exclude... ✅ Succeeded 25s View ↗
Additional runs (26) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-12-17 08:58:48 UTC

@ntdiary ntdiary changed the title chore: explore switching two test file to vfs chore: explore switching two test file to VFS Dec 18, 2025
@auvred auvred mentioned this pull request Jan 1, 2026
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Explore switching tests to @typescript/vfs

1 participant

@ntdiary