Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(eslint-plugin-internal): [no-multiple-lines-of-errors] add rule #11899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JoshuaKGoldberg wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(eslint-plugin-internal): [no-multiple-lines-of-errors] add rule #11899

JoshuaKGoldberg wants to merge 5 commits into from
+564 −77

Conversation

@JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Dec 29, 2025 •
edited
Loading

PR Checklist

Overview

Adds and enables the lint rule internally. There were pleasantly surprisingly few existing reported cases. I cleaned up the ones that could be, and ignored the others where the rule needed it.

Extracts a shared getRuleTesterCallObject to reuse the logic from no-dynamic-tests.

💖

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Dec 29, 2025

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Dec 29, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 8773247
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/6952de9c49290e0008e1818d
😎 Deploy Preview https://deploy-preview-11899--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🟢 up 6 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link

nx-cloud bot commented Dec 29, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 8773247

Command Status Duration Result
nx run-many -t lint ✅ Succeeded 3m 10s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 4s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 11s View ↗
nx run integration-tests:test ✅ Succeeded 5s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 1s View ↗
nx run generate-configs ✅ Succeeded 7s View ↗
nx run types:build ✅ Succeeded 1s View ↗
nx run-many --target=build --parallel --exclude... ✅ Succeeded 6s View ↗
Additional runs (28) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-12-29 20:15:22 UTC

@codecov
Copy link

codecov bot commented Dec 29, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.69%. Comparing base (e4c57f5) to head (8773247).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11899      +/-   ##
==========================================
+ Coverage   90.67%   90.69%   +0.01%     
==========================================
  Files         524      527       +3     
  Lines       53476    53583     +107     
  Branches     8928     8963      +35     
==========================================
+ Hits        48490    48597     +107     
  Misses       4973     4973              
  Partials       13       13
Flag Coverage Δ
unittest 90.69% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...lint-plugin-internal/src/rules/no-dynamic-tests.ts 95.57% <100.00%> (+1.97%) ⬆️
...-internal/src/rules/no-multiple-lines-of-errors.ts 100.00% <100.00%> (ø)
...lugin-internal/src/util/getRuleTesterCallObject.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review December 29, 2025 20:19
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team December 29, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Repo: Internal lint rule against multiple errors across multiple lines in tests

1 participant

@JoshuaKGoldberg