Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Dec 29, 2025

PR Checklist

Overview

Explicitly mentions and links to projectService, to make it clear that tsconfigRootDir does apply to both project and projectService.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Dec 29, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit d0c855c
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/6952d86f4a1fca0008c65c6a
😎 Deploy Preview https://deploy-preview-11903--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 8 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

For an option that allows linting files outside of your TSConfig file(s), see [`projectService`](#projectservice).

### Usage with `projectService`
#### Usage with `projectService`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(a little oopsy from #11875)

@nx-cloud
Copy link

nx-cloud bot commented Dec 29, 2025

View your CI Pipeline Execution ↗ for commit d0c855c

Command Status Duration Result
nx run-many -t lint ✅ Succeeded 3m 9s View ↗
nx run-many -t typecheck ✅ Succeeded 1m 52s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 4s View ↗
nx run integration-tests:test ✅ Succeeded 5s View ↗
nx run generate-configs ✅ Succeeded 8s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 1s View ↗
nx run types:build ✅ Succeeded 2s View ↗
nx run-many --target=build --parallel --exclude... ✅ Succeeded 7s View ↗
Additional runs (28) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-12-29 19:50:42 UTC

@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.67%. Comparing base (e4c57f5) to head (d0c855c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11903      +/-   ##
==========================================
- Coverage   90.67%   90.67%   -0.01%     
==========================================
  Files         524      525       +1     
  Lines       53476    53491      +15     
  Branches     8928     8930       +2     
==========================================
+ Hits        48490    48502      +12     
- Misses       4973     4976       +3     
  Partials       13       13              
Flag Coverage Δ
unittest 90.67% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team December 29, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: Explain how tsconfigRootDir interacts with projectService

1 participant