chore: extract syntax check (part 2) #11905
Conversation
|
Thanks for the PR, @fisker! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 8bc8e53
☁️ Nx Cloud last updated this comment at |
c71ec01 to
4854209
Compare
4854209 to
248fb70
Compare
| if (node.expression.kind !== SyntaxKind.StringLiteral) { | ||
| throw createError(node.expression, 'String literal expected.'); | ||
| } | ||
| break; |
There was a problem hiding this comment.
@JoshuaKGoldberg Now you can see why I insist one single call in convert.ts, otherwise we need to create and call so many functions.
There was a problem hiding this comment.
Ha, yeah, I do see what you mean!
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (22.86%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #11905 +/- ##
==========================================
- Coverage 90.67% 90.64% -0.04%
==========================================
Files 525 525
Lines 53491 53535 +44
Branches 8930 8946 +16
==========================================
+ Hits 48502 48525 +23
- Misses 4976 4997 +21
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
PR Checklist
Converter#11695Overview
Second part of ##11695
Follow up #11748