fix(eslint-plugin): [no-useless-default-assignment] handle conditional initializer #11908
Conversation
|
Thanks for the PR, @ulrichstark! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 0e2958d
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11908 +/- ##
=======================================
Coverage 90.67% 90.67%
=======================================
Files 525 525
Lines 53491 53502 +11
Branches 8930 8938 +8
=======================================
+ Hits 48502 48513 +11
Misses 4976 4976
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
LGTM! Just one note that we can always edit in before merge. Thanks! ✨
| // https://github.com/typescript-eslint/typescript-eslint/issues/11850 | ||
| ` | ||
| const { a = 'default' } = Math.random() > 0.5 ? { a: 'Hello' } : {}; | ||
| `, |
There was a problem hiding this comment.
[Testing] Just to be safe, could you add in testing for nested ternaries? Checks for specifically conditionals sometimes only work for one level.
const { a = 'default' } = Math.random() > 0.5 ?
Math.random() > 0.5
? { a: 'Hello' }
: {}
: {};
PR Checklist
Overview