Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test(typescript-estree): alignment tests for TemplateLiteral node #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 9, 2020
Merged

test(typescript-estree): alignment tests for TemplateLiteral node #1421

merged 6 commits into from
Jan 9, 2020

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Jan 9, 2020

Currently we are disabling all tests that contains template literals, this PR changes that

@typescript-eslint

This comment has been minimized.

Sign in to view
@armano2 armano2 added package: typescript-estree Issues related to @typescript-eslint/typescript-estree tests anything to do with testing labels Jan 9, 2020
@armano2 armano2 changed the title test(typescript-estree): alignment tests for TemplateLiteral test(typescript-estree): alignment tests for TemplateLiteral node Jan 9, 2020
@armano2 armano2 self-assigned this Jan 9, 2020
@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #1421 into master will decrease coverage by 0.01%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           master    #1421      +/-   ##
==========================================
- Coverage   94.48%   94.47%   -0.02%     
==========================================
  Files         140      141       +1     
  Lines        6056     6058       +2     
  Branches     1721     1721              
==========================================
+ Hits         5722     5723       +1     
- Misses        181      182       +1     
  Partials      153      153
Impacted Files Coverage Δ
...nt-plugin/src/rules/no-unused-vars-experimental.ts 91.39% <ø> (ø) ⬆️
...slint-plugin/src/rules/no-unnecessary-qualifier.ts 96.15% <ø> (ø) ⬆️
...ages/eslint-plugin/src/rules/prefer-regexp-exec.ts 100% <ø> (ø) ⬆️
.../eslint-plugin/src/rules/promise-function-async.ts 100% <ø> (ø) ⬆️
...slint-plugin/src/rules/no-unnecessary-condition.ts 99.01% <ø> (ø) ⬆️
...-plugin/src/rules/restrict-template-expressions.ts 100% <ø> (ø) ⬆️
packages/typescript-estree/src/ts-estree/index.ts 100% <ø> (ø) ⬆️
.../eslint-plugin/src/rules/restrict-plus-operands.ts 100% <ø> (ø) ⬆️
...plugin/src/rules/prefer-string-starts-ends-with.ts 100% <ø> (ø) ⬆️
...pt-estree/src/ts-estree/estree-to-ts-node-types.ts 0% <0%> (ø)
... and 13 more

bradzacher
bradzacher approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for auditing all of this alignment code!

@bradzacher bradzacher merged commit 42b0fcc into typescript-eslint:master Jan 9, 2020
@armano2 armano2 deleted the alignment-testsx branch January 9, 2020 23:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees

@armano2 armano2

Labels
package: typescript-estree Issues related to @typescript-eslint/typescript-estree tests anything to do with testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armano2 @bradzacher