test: fix vscode launch configuration for windows #1523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #1523 +/- ##
=======================================
Coverage 95.49% 95.49%
=======================================
Files 150 150
Lines 6639 6639
Branches 1880 1880
=======================================
Hits 6340 6340
Misses 112 112
Partials 187 187
|
bradzacher
requested changes
Jan 26, 2020
.vscode/launch.json
Outdated
| "--runInBand", | ||
| "--no-cache", | ||
| "--no-coverage", | ||
| "${fileBasename}" |
There was a problem hiding this comment.
This should be fileBasenameNoExtension
fileBasename will include .ts, which means you can only run the test if you open the test file (because semi.ts won't match semi.test.ts)
Suggested change
| "${fileBasename}" | |
| "${fileBasenameNoExtension}" |
.vscode/launch.json
Outdated
| "--runInBand", | ||
| "--no-cache", | ||
| "--no-coverage", | ||
| "${fileBasename}" |
There was a problem hiding this comment.
Suggested change
| "${fileBasename}" | |
| "${fileBasenameNoExtension}" |
bradzacher
approved these changes
Jan 26, 2020
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1519