docs(typescript-estree): warn users about performance of glob in project option #2602
Conversation
|
Thanks for the PR, @tosmolka! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
|
Have you got examples of slowness? I'd much rather start with an issue here to look into and discuss rather than just straight up updating docs. Please file an issue with a repro of a perf issue so we can investigate accordingly. |
When parser resolves project files referenced via glob pattern - it does so for every single scanned file individually. This causes huge performance downgrade when scanning large projects and using wide glob pattern (e.g. **/tsconfig.json).
We could consider improving performance in such cases (maybe caching?) but in the meantime, I am proposing addition to docs that warns users about this corner case.
Any feedback appreciated!