feat(experimental-utils): add onCodePathStart and onCodePathEnd to RuleListener #2930
Conversation
|
Thanks for the PR, @wcandillon! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
|
I realize that this type can be extended via createRule so this might not be necessary. |
There was a problem hiding this comment.
the reason this was never added was because TS does not allow you to mix known properties with an index signature unless that index signature exactly matches all known properties.
So by adding these two signatures (as you can see) this causes a hard failure in TS because (codePath: { id: string }) => void is not assignable to RuleFunction.
I don't know of a way to solve this.
No description provided.