refactor(typescript-estree): add missing type guards to node utils #3102
Conversation
|
Thanks for the PR, @armano2! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #3102 +/- ##
==========================================
- Coverage 92.87% 92.87% -0.01%
==========================================
Files 314 314
Lines 10672 10670 -2
Branches 3027 3026 -1
==========================================
- Hits 9912 9910 -2
Misses 344 344
Partials 416 416
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| return ( | ||
| isChainExpression(child) && | ||
| // (x?.y).z is semantically different, and as such .z is no longer optional | ||
| node.expression.kind !== ts.SyntaxKind.ParenthesizedExpression | ||
| ) { | ||
| return true; | ||
| } | ||
|
|
||
| return false; | ||
| ); |
There was a problem hiding this comment.
coverage changed, this change reduces cyclomatic complexity of this function
This PR adds few missing typeguards to node utility functions