Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: FAQ: update prettier config for v8 #3103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2021

Conversation

fuxingloh
Copy link
Contributor

What's changed

Prettier config has since been merged into one, hence prettier/@typescript-eslint is deprecated/removed from latest release. All you need to do is declare prettier now.

https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21

Why should this be merged

While installing typescript-eslint for a new project, I wasted a few minutes trying to look find where is this prettier/@typescript-eslint to install.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @fuxingloh!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

It's probably worth adding a note below this saying that versions of eslint-config-prettier less than v8 will require prettier/@typescript-eslint.

I just want to stave off issues about people using an older version, running into problems and filing an issue.

@fuxingloh fuxingloh requested a review from bradzacher February 24, 2021 09:12
bradzacher
bradzacher previously approved these changes Feb 24, 2021
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

@bradzacher bradzacher changed the title docs: prettier config merged into one docs: FAQ: update prettier config for v8 Feb 24, 2021
@bradzacher bradzacher merged commit 5e2a993 into typescript-eslint:master Feb 24, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants