Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(eslint-plugin): fix missing periods in rule messages #3789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2021
Merged

chore(eslint-plugin): fix missing periods in rule messages #3789

merged 1 commit into from
Sep 3, 2021

Conversation

vostrnad
Copy link
Contributor

Revisiting #1935 a year later – some rule messages are missing a period at the end, and there is one instance of a message beginning with a lowercase letter.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @vostrnad!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Aug 24, 2021 •
edited
Loading

Codecov Report

Merging #3789 (6b9d3f7) into master (a752638) will increase coverage by 0.89%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3789      +/-   ##
==========================================
+ Coverage   92.68%   93.57%   +0.89%     
==========================================
  Files         327      147     -180     
  Lines       11351     7864    -3487     
  Branches     3201     2490     -711     
==========================================
- Hits        10521     7359    -3162     
+ Misses        369      161     -208     
+ Partials      461      344     -117
Flag Coverage Δ
unittest 93.57% <ø> (+0.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lugin/src/rules/consistent-indexed-object-style.ts 90.00% <ø> (ø)
...eslint-plugin/src/rules/consistent-type-imports.ts 93.58% <ø> (ø)
...lugin/src/rules/no-confusing-non-null-assertion.ts 82.60% <ø> (ø)
...t-plugin/src/rules/no-confusing-void-expression.ts 98.82% <ø> (ø)
...es/eslint-plugin/src/rules/no-duplicate-imports.ts 97.77% <ø> (ø)
...s/eslint-plugin/src/rules/no-implicit-any-catch.ts 84.61% <ø> (ø)
...es/eslint-plugin/src/rules/no-invalid-void-type.ts 95.23% <ø> (ø)
...slint-plugin/src/rules/no-unnecessary-condition.ts 97.17% <ø> (ø)
...slint-plugin/src/rules/prefer-enum-initializers.ts 100.00% <ø> (ø)
...eslint-plugin/src/rules/prefer-return-this-type.ts 90.47% <ø> (ø)
... and 180 more

@nx-cloud
Copy link

nx-cloud bot commented Aug 24, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 6b9d3f7. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin-internal
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx run-many --target=typecheck --all --parallel
#000000 nx run-many --target=build --all --parallel
#000000 nx test @typescript-eslint/parser
#000000 nx test @typescript-eslint/experimental-utils
#000000 nx test @typescript-eslint/scope-manager
#000000 nx test @typescript-eslint/parser
#000000 nx test @typescript-eslint/visitor-keys
#000000 nx test @typescript-eslint/experimental-utils
#000000 nx test @typescript-eslint/typescript-estree
#000000 nx test @typescript-eslint/scope-manager
#000000 nx run-many --target=build --all --parallel
#000000 nx test @typescript-eslint/visitor-keys
#000000 nx test @typescript-eslint/typescript-estree

Sent with 💌 from NxCloud.

@bradzacher bradzacher added the bug Something isn't working label Sep 3, 2021
bradzacher
bradzacher approved these changes Sep 3, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!
We should probably look into something like this lint rule to help enforce the format.

@bradzacher bradzacher merged commit bb72fd6 into typescript-eslint:master Sep 3, 2021
@vostrnad vostrnad deleted the rule-messages-periods branch September 3, 2021 17:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vostrnad @MichaelDeBoey @bradzacher