fix(eslint-plugin): prevented a regression for a fixed issue (#119) #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luckeu
pushed a commit
to Luckeu/typescript-eslint
that referenced
this pull request
Jun 27, 2024
When `ignoreStringLiterals` is enabled, only template literals are reported, not string literals. Closes typescript-eslint#400
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested #119 and saw that the issue does not exist anymore. So I just added a test case to close the issue.
I have made this a draft so that I can see if my local set up was proper.I just realized my mistake. Back to the draft status for now.