Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs(eslint-plugin): [consistent-type-definitions] fix a typo #4009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2021
Merged

docs(eslint-plugin): [consistent-type-definitions] fix a typo #4009

merged 1 commit into from
Oct 14, 2021

Conversation

aateeque
Copy link
Contributor

Seems like the interface option was intended

@aateeque
Looks like a typo
7baf817 
Seems like the `interface` option was intended
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @aateeque!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Oct 14, 2021 •
edited
Loading

Codecov Report

Merging #4009 (7baf817) into master (8605e08) will increase coverage by 0.60%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4009      +/-   ##
==========================================
+ Coverage   92.80%   93.40%   +0.60%     
==========================================
  Files         331      151     -180     
  Lines       11598     8093    -3505     
  Branches     3272     2568     -704     
==========================================
- Hits        10763     7559    -3204     
+ Misses        364      181     -183     
+ Partials      471      353     -118
Flag Coverage Δ
unittest 93.40% <ø> (+0.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/scope-manager/src/lib/esnext.full.ts
packages/scope-manager/src/lib/index.ts
.../experimental-utils/src/eslint-utils/RuleTester.ts
packages/scope-manager/src/lib/es2021.ts
...scope-manager/src/definition/VariableDefinition.ts
packages/scope-manager/src/lib/es2018.promise.ts
...utils/src/ast-utils/eslint-utils/PatternMatcher.ts
...ages/scope-manager/src/referencer/ExportVisitor.ts
packages/typescript-estree/src/convert-comments.ts
...ges/typescript-estree/src/create-program/shared.ts
... and 170 more

@nx-cloud
Copy link

nx-cloud bot commented Oct 14, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 7baf817. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx run-many --target=typecheck --all --parallel
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx test @typescript-eslint/scope-manager
#000000 Node 12.x - nx test @typescript-eslint/visitor-keys
#000000 Node 12.x - nx run-many --target=build --all --parallel
#000000 Node 12.x - nx test @typescript-eslint/typescript-estree
#000000 Node 12.x - nx run-many --target=build --all --parallel
#000000 Node 12.x - nx run-many --target=build --all --parallel
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils

Sent with 💌 from NxCloud.

@bradzacher bradzacher changed the title Looks like a typo docs(eslint-plugin): [consistent-type-definitions] fix a typo Oct 14, 2021
@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Oct 14, 2021
bradzacher
bradzacher approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher merged commit b43fda7 into typescript-eslint:master Oct 14, 2021
@aateeque aateeque deleted the patch-1 branch October 14, 2021 18:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aateeque @bradzacher