Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs(website): fix heading level inconsistencies #4320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 20, 2021

Conversation

Josh-Cena
Copy link
Member

PR Checklist

Overview

Make the TOC more consistent and easier to navigate

@nx-cloud
Copy link

nx-cloud bot commented Dec 17, 2021

☁️ Nx Cloud Report

CI ran the following commands for commit 62f86e2. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 44 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Josh-Cena!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Dec 17, 2021

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: 62f86e2

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61bff25cf019fb00075183ec

@Josh-Cena
Copy link
Member Author

This looks quite problematic (also in other PRs). I can't see why the build fails

@armano2 armano2 added the documentation Documentation ("docs") that needs adding/updating label Dec 17, 2021
armano2
armano2 previously approved these changes Dec 17, 2021
@armano2 armano2 added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Dec 17, 2021
@bradzacher
Copy link
Member

no need to bother with merging main into your branch - we can keep track of what gets merged and merge for you if it's required before landing the PR :)

@Josh-Cena
Copy link
Member Author

Yeah, just getting bored & hitting the "update" button🙈 Hope it doesn't get confusing

@Josh-Cena
Copy link
Member Author

Meanwhile I still have no clue about the failing Netlify build...

@bradzacher
Copy link
Member

Meanwhile I still have no clue about the failing Netlify build...

That's on our end.. we need to fix our build step.
I believe it's something like we're not building the entire project and instead building a smaller part of it? I don't know exactly as I haven't seen the build config!

@bradzacher bradzacher merged commit 234be00 into typescript-eslint:main Dec 20, 2021
@Josh-Cena Josh-Cena deleted the jc/doc-heading branch December 20, 2021 03:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge documentation Documentation ("docs") that needs adding/updating
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants