☁️ Nx Cloud Report

CI is running/has finished running commands for commit cb99e3e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Sent with 💌 from NxCloud.

Thanks for the PR, @Josh-Cena!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	cb99e3e
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/625eab0cc90f960009f1c189
😎 Deploy Preview	https://deploy-preview-4692--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

The Cypress failure looks suspicious. It wasn't like this before. Does that mean there are new a11y regressions in Docusaurus itself?

Huh, the contrast problem is indeed gone—very weird! We probably need to update the palette somehow, as the current dark mode palette in production is absolutely less accessible than it should.

Now blocked on #4739

@Josh-Cena I'm hoping #4740 fixed that one. Updating this branch to the newest main to check... 🤞

Ooops, no 😞

😭

Looking at the log, looks like Cypress is trying to connect before the client is even ready

I wonder if we can yarn start first, and then let Cypress connect in the next step?

It's configured in ci.yml with the native Cypress start:

- name: Cypress run
  uses: cypress-io/github-action@v2
  with:
    project: ./packages/website
    start: yarn start

...maybe it's a performance issue somewhere? https://github.com/cypress-io/github-action#wait-on might help. I'm on mobile right now but can try it tomorrow-ish if you don't have time before then.

Mostly just unfamiliarity with Cypress 😄 If you have a plan already I'd let you handle that

@Josh-Cena you can check #4771, this should make it work and let us work with dark/light mode

@armano2 Instead of stacking duplicate selectors (:root and html are equivalent) to increase its specificity, I'd rather decrease the specificity of both. WDYT?

@armano2 Instead of stacking duplicate selectors (:root and html are equivalent) to increase its specificity, I'd rather decrease the specificity of both. WDYT?

@Josh-Cena I'm ok with this change, but we are having issue now with how :root is merged

overrides has lower priority than colors defined in docusaurus,

{
  "id": "color-contrast",
  "data": {
    "fgColor": "#969faf",
    "bgColor": "#ebedf0",
    "contrastRatio": 2.27,
    "fontSize": "12.0pt (16px)",
    "fontWeight": "normal",
    "messageKey": null,
    "expectedContrastRatio": "4.5:1"
  },
  "relatedNodes": [
    {
      "html": "<button type=\"button\" class=\"DocSearch DocSearch-Button\" aria-label=\"Search\">",
      "target": [".DocSearch"]
    }
  ],
  "impact": "serious",
  "message": "Element has insufficient color contrast of 2.27 (foreground color: #969faf, background color: #ebedf0, font size: 12.0pt (16px), font weight: normal). Expected contrast ratio of 4.5:1"
}

live:

this branch:

Okay, I see. Reverted CSS changes. Probably related to facebook/docusaurus#3678

Codecov Report

Merging #4692 (cb99e3e) into main (84d2d28) will increase coverage by 0.83%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4692      +/-   ##
==========================================
+ Coverage   91.75%   92.59%   +0.83%     
==========================================
  Files         226      186      -40     
  Lines       10558    10133     -425     
  Branches     3263     3215      -48     
==========================================
- Hits         9688     9383     -305     
+ Misses        590      501      -89     
+ Partials      280      249      -31     

Flags with carried forward coverage won't be shown. Click here to find out more.

@bradzacher I think we can get this merged today? It's now a trivial version bump and from my manual visual testing there seems to be no regressions. I don't have plans about when beta.19 will be out, but probably not this week (since we haven't completed the main features yet), so this should be good to merge.

I don't know what the Cypress test is up to but since the color mode toggle has changed... The failure is kinda expected.

cc @JoshuaKGoldberg for the cypress failure:

1) Index
       has no accessibility issues detected by aXe:
     AssertionError: Timed out retrying after 4000ms: Expected to find content: '🌞' but never did.
      at Context.eval (http://localhost:3000/__cypress/tests?p=cypress/integration/index.spec.js:108:8)

I tried retrying the test and it failed in the same way.

That '🌞' used to be a part of the color mode toggle, and the latter is now SVG based.

Ah. So then the test is failing not as a false positive, but because the upgrade broke it.

We'll need to fix that as part of this PR.

https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/website/cypress/integration/index.spec.js#L12

Ah, I see. Thanks for the pointer!