-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Update comma-dangle.md #4827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update comma-dangle.md #4827
Conversation
Added note for 404 link.
Thanks for the PR, @be-codified! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should instead just update the link to point at the correct URL.
Codecov Report
@@ Coverage Diff @@
## main #4827 +/- ##
==========================================
+ Coverage 93.96% 94.24% +0.28%
==========================================
Files 172 151 -21
Lines 9818 8230 -1588
Branches 3105 2676 -429
==========================================
- Hits 9225 7756 -1469
+ Misses 353 262 -91
+ Partials 240 212 -28
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks for noticing this!
A more user-helpful fix would be to correct the link to https://eslint.org/docs/rules/comma-dangle. Could you do that instead please?
Added link.
Added anchor to the link.
@JoshuaKGoldberg sure, I have also added anchor for options. Keep up the good work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@JoshuaKGoldberg dont forget to update the commit message before merging next time! |
GH quirk: if there are multiple commits in the branch, the squash-merge commit's message would take the PR title; otherwise, the commit message would be that single commit's message, disregarding the PR title. Regardless, I would recommend always normalizing the PR title as well. |
Oop sorry, yes! |
Added note for 404 link.
PR Checklist
Overview