Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update comma-dangle.md #4827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2022
Merged

Conversation

ZigaVukcevicDev
Copy link
Contributor

Added note for 404 link.

PR Checklist

Overview

Added note for 404 link.
@nx-cloud
Copy link

nx-cloud bot commented Apr 15, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2ce8e48. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 43 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @be-codified!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Apr 15, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 2ce8e48
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6259e1544a8a7100076cb382
😎 Deploy Preview https://deploy-preview-4827--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should instead just update the link to point at the correct URL.

@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #4827 (2ce8e48) into main (18a81cb) will increase coverage by 0.28%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #4827      +/-   ##
==========================================
+ Coverage   93.96%   94.24%   +0.28%     
==========================================
  Files         172      151      -21     
  Lines        9818     8230    -1588     
  Branches     3105     2676     -429     
==========================================
- Hits         9225     7756    -1469     
+ Misses        353      262      -91     
+ Partials      240      212      -28     
Flag Coverage Δ
unittest 94.24% <83.33%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/eslint-plugin/src/rules/no-magic-numbers.ts 80.64% <83.33%> (-2.05%) ⬇️
...plugin-internal/src/rules/prefer-ast-types-enum.ts
...lugin-internal/src/rules/plugin-test-formatting.ts
...-estree/src/create-program/createDefaultProgram.ts
packages/typescript-estree/src/ts-estree/index.ts
...-estree/src/create-program/createProjectProgram.ts
...gin-internal/src/rules/no-poorly-typed-ts-props.ts
...ckages/typescript-estree/src/jsx/xhtml-entities.ts
...escript-estree/src/semantic-or-syntactic-errors.ts
packages/typescript-estree/src/ast-converter.ts
... and 12 more

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks for noticing this!

A more user-helpful fix would be to correct the link to https://eslint.org/docs/rules/comma-dangle. Could you do that instead please?

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Apr 15, 2022
Added anchor to the link.
@ZigaVukcevicDev
Copy link
Contributor Author

@JoshuaKGoldberg sure, I have also added anchor for options. Keep up the good work.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) April 16, 2022 01:46
@JoshuaKGoldberg JoshuaKGoldberg merged commit 42ec8fd into typescript-eslint:main Apr 16, 2022
@bradzacher
Copy link
Member

@JoshuaKGoldberg dont forget to update the commit message before merging next time!

@Josh-Cena
Copy link
Member

Josh-Cena commented Apr 16, 2022

GH quirk: if there are multiple commits in the branch, the squash-merge commit's message would take the PR title; otherwise, the commit message would be that single commit's message, disregarding the PR title. Regardless, I would recommend always normalizing the PR title as well.

@JoshuaKGoldberg
Copy link
Member

Oop sorry, yes!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting response Issues waiting for a reply from the OP or another party
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants