Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: replace issue templates with issue forms #4897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 10, 2022
Merged

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented May 3, 2022

PR Checklist

Overview

Adds issue templates using GH's forms config.
Deletes now obsolete markdown templates.

We can't test them in this repo, but I've uploaded them to another test repo.
https://github.com/bradzacher/test-issue-form/issues/new/choose

image

@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label May 3, 2022
@bradzacher bradzacher requested a review from JoshuaKGoldberg May 3, 2022 08:26
@nx-cloud
Copy link

nx-cloud bot commented May 3, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a048cc4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 43 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented May 3, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit a048cc4
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6279cbbc622f1b00081117f4
😎 Deploy Preview https://deploy-preview-4897--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bradzacher bradzacher force-pushed the issue-forms branch 2 times, most recently from a52c231 to 386a586 Compare May 3, 2022 08:36
-   [x] Addresses an existing open issue: fixes #4823
-   [x] That issue was marked as [accepting prs](https://github.com/typescript-eslint/typescript-eslint/issues?q=is%3Aopen+is%3Aissue+label%3A%22accepting+prs%22)
-   [x] Steps in [CONTRIBUTING.md](https://github.com/typescript-eslint/typescript-eslint/blob/main/CONTRIBUTING.md) were taken

Adds issue templates using GH's forms config.
Deletes now obselete markdown templates.

We can't *use* them, but GH will at least preview render them when viewed on the branch:
- [Bug: Report a complex bug with repro
repo](https://github.com/typescript-eslint/typescript-eslint/tree/issue-forms/.github/ISSUE_TEMPLATE/bug-report-complex.yaml)
- [Bug: Report a Bug With the
Parser](https://github.com/typescript-eslint/typescript-eslint/tree/issue-forms/.github/ISSUE_TEMPLATE/bug-report-parser.yaml)
- [Bug: Report a Bug With a
Rule](https://github.com/typescript-eslint/typescript-eslint/tree/issue-forms/.github/ISSUE_TEMPLATE/bug-report-plugin.yaml)
- [Bug: Report a Bug With Scope
Analysis](https://github.com/typescript-eslint/typescript-eslint/tree/issue-forms/.github/ISSUE_TEMPLATE/bug-report-scope-manager.yaml)
- [Bug: Report a Bug With utils /
type-utils](https://github.com/typescript-eslint/typescript-eslint/tree/issue-forms/.github/ISSUE_TEMPLATE/bug-report-utils.yaml)
- [Enhancement: Propose a New Base Rule
Extension](https://github.com/typescript-eslint/typescript-eslint/tree/issue-forms/.github/ISSUE_TEMPLATE/enhancement-new-base-rule-extension.yaml)
- [Enhancement: Propose a New
Rule](https://github.com/typescript-eslint/typescript-eslint/tree/issue-forms/.github/ISSUE_TEMPLATE/enhancement-new-rule.yaml)
- [Enhancement: Propose a New Rule Option Or Additional
Checks](https://github.com/typescript-eslint/typescript-eslint/tree/issue-forms/.github/ISSUE_TEMPLATE/enhancement-rule-option.yaml)
@Josh-Cena
Copy link
Member

You can always make your forked repo, and apply your changes there, though!

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, awesome stuff! Thanks!!

Posted a bunch of suggestions. Really looking forward to having this! ✨🔥

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label May 5, 2022
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label May 5, 2022
@bradzacher bradzacher requested a review from JoshuaKGoldberg May 5, 2022 20:13
armano2
armano2 previously approved these changes May 6, 2022
@bradzacher
Copy link
Member Author

bradzacher commented May 10, 2022

@JoshuaKGoldberg - are you happy with the changes and the wizard ordering, etc?

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is wonderful, thank you! 🙏

@bradzacher bradzacher merged commit bd86742 into main May 10, 2022
@bradzacher bradzacher deleted the issue-forms branch May 10, 2022 02:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should all issue templates be in the new forms format?
4 participants