chore(website): update config editor and add tabs to playground #5088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error fallback to error list
…o-default-fix-ts-4.0.5
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…ser is correctly stored
…ents to mobile version
This comment was marked as resolved.
This comment was marked as resolved.
JoshuaKGoldberg
requested changes
May 29, 2022
There was a problem hiding this comment.
Looks great! Feels better than always using a modal.
Requesting changes for the accessibility of the buttons. Long term we probably will want to set up a design system using some accessible base system to make tab components and the like easier. But for now this is a great start.
!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
configs are displayed as tabs
reduce computation complexity when updating codeFixers
In case of fatal parsing error fallback to error list, this unifies how errors are displayed between screens
Old:
New:
ensure that all proper libs are download for specified typescript versions
typescript errors markers are going to be now printed only for user provided file with exclusion to externally provided files
Old:
New:
small adjustments to mobile version
any config provided by user will be saved but may not be used if validation/parsing fails for it
we are currently using only compilerOptions and rules field from configs provided by user
modal with visual config has been moved to right side after selecting tab
autocompletion for eslintrc and tsconfig has been added
json parsing errors are displayed live from monaco
url format has changed
tsconfigandeslintrcare now used instead ofrulesandtsConfig, backward compatibility layer is in placecorrect bug with event missing in monaco for ts <= 4.0.5 Add onDidChangeModelMarkers to IEditor interface microsoft/monaco-editor#313