fix: prefer-optional-chain.ts requiresTypeChecking #5318
Conversation
This rule calls `util.getParserServices` so it's a `requiresTypeChecking`-rule
|
Thanks for the PR, @xcatliu! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Hi @xcatliu - when we say we want to add type information - we mean we want to update the rule to consume types so that it's more accurate.
This flag by itself doesn't do anything towards that objective!
It's going to be a decent amount of work to do this - more than happy if you want to tackle it!
Feel free to reopen this PR if you'd like to give it a go.
PR Checklist
Overview
This rule calls
util.getParserServicesso it's arequiresTypeChecking-rule