-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
test: add regression testing against old TS and ESLint versions in the CI #5573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ee3b014
to
25fb41d
Compare
The actions are all setup and working just fine, but there is two problems to solve.
We need a way to:
|
bb29bd7
to
f0461a9
Compare
PRIMARY_NODE_VERSION: 18 | ||
PRIMARY_TYPESCRIPT_VERSION: '~4.8.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
side note that i hate that this is yet another thing for us to remember to keep in sync.
Lots of merge conflicts and this is taking up space in the PR queue. I'm going to close this old draft just to keep the queue small. |
PR Checklist
Overview
#5571 shows that we really need to be testing against old TS versions.
This PR adds testing to the CI so that we can at least catch it.