Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(eslint-plugin): [no-unused-vars] check if any variable definition is exported #6873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 17, 2023
+34 −5
Merged

fix(eslint-plugin): [no-unused-vars] check if any variable definition is exported #6873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
36195e6
fix #6188
Maxim-Mazurok Apr 9, 2023
7fc9a9a
optimize
Maxim-Mazurok Apr 9, 2023
7353106
add tests
Maxim-Mazurok Apr 16, 2023
95dd600
Merge branch 'main' into main
Maxim-Mazurok Apr 16, 2023
35462fc
nit: simplify to .some
JoshuaKGoldberg Jul 16, 2023
167de44
Merge branch 'main' into Maxim-Mazurok/main
JoshuaKGoldberg Jul 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions packages/eslint-plugin/src/util/collectUnusedVariables.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,9 +426,7 @@ function isMergableExported(variable: TSESLint.Scope.Variable): boolean {
* @returns True if the variable is exported, false if not.
*/
function isExported(variable: TSESLint.Scope.Variable): boolean {
const definition = variable.defs[0];

if (definition) {
return variable.defs.some(definition => {
let node = definition.node;

if (node.type === AST_NODE_TYPES.VariableDeclarator) {
Expand All @@ -438,8 +436,7 @@ function isExported(variable: TSESLint.Scope.Variable): boolean {
}

return node.parent!.type.indexOf('Export') === 0;
}
return false;
});
}

/**
Expand Down
32 changes: 32 additions & 0 deletions packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1080,6 +1080,18 @@ export class Foo {
typescript: '4.4',
},
},
`
interface Foo {
bar: string;
}
export const Foo = 'bar';
`,
`
export const Foo = 'bar';
interface Foo {
bar: string;
}
`,
],

invalid: [
Expand Down Expand Up @@ -1805,5 +1817,25 @@ x = foo(x);
},
],
},
{
code: `
interface Foo {
bar: string;
}
const Foo = 'bar';
`,
errors: [
{
messageId: 'unusedVar',
line: 5,
column: 7,
data: {
varName: 'Foo',
action: 'assigned a value',
additional: '',
},
},
],
},
],
});