Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test: add integration test for plugins together #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2019

Conversation

JamesHenry
Copy link
Member

@JamesHenry JamesHenry commented Jan 19, 2019

  • Removes all the old integration tests from typescript-eslint-parser, they are not so useful any more now that our unit tests cover some fundamental integration points implicitly

  • Adds a new way of doing the integration test using some docker magic and writing a snapshot back to the outside world ✨

  • Adds an integration test for using both plugins together in the same project 😍

https://github.com/typescript-eslint/typescript-eslint/blob/6cb1e04af20be21b7895b9ef8103e0ba272947c4/tests/integration/fixtures/typescript-and-tslint-plugins-together/test.js.snap

@JamesHenry
Copy link
Member Author

The second commit is just reverting renames, the first commit contains the relevant changes

@codecov
Copy link

codecov bot commented Jan 19, 2019

Codecov Report

Merging #72 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   94.77%   94.77%           
=======================================
  Files          48       48           
  Lines        2469     2469           
  Branches      381      381           
=======================================
  Hits         2340     2340           
  Misses         77       77           
  Partials       52       52
Impacted Files Coverage Δ
packages/eslint-plugin-tslint/src/index.ts 90% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf58003...87a444a. Read the comment docs.

@JamesHenry JamesHenry merged commit 154287d into master Jan 19, 2019
@JamesHenry JamesHenry deleted the integration-tests branch January 19, 2019 00:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants