Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: blog post on parserOptions.project = true #7368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 16, 2023
Merged

docs: blog post on parserOptions.project = true #7368

merged 10 commits into from
Sep 16, 2023

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jul 28, 2023 •
edited
Loading

PR Checklist

Overview

Adds a blog post explaining:

  • The current state of parserOptions.project options
  • Why we added project: true
  • Benefits of that new option
  • How it works at a very high level
  • Next steps

References:

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Jul 28, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 0368db6
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6500b3257be7fe00083eff4c
😎 Deploy Preview https://deploy-preview-7368--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg JoshuaKGoldberg added the DO NOT MERGE PRs which should not be merged yet label Jul 28, 2023
@nx-cloud
Copy link

nx-cloud bot commented Jul 28, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0368db6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 20 targets

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Jul 28, 2023 •
edited
Loading

Codecov Report

Merging #7368 (fbcc812) into main (4f34d0b) will increase coverage by 0.00%.
Report is 46 commits behind head on main.
The diff coverage is n/a.

❗ Current head fbcc812 differs from pull request most recent head 0368db6. Consider uploading reports for the commit 0368db6 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7368   +/-   ##
=======================================
  Coverage   87.23%   87.23%           
=======================================
  Files         387      387           
  Lines       13401    13404    +3     
  Branches     3962     3962           
=======================================
+ Hits        11690    11693    +3     
  Misses       1327     1327           
  Partials      384      384
Flag Coverage Δ
unittest 87.23% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@JoshuaKGoldberg JoshuaKGoldberg changed the title WIP: blog post on parserOptions.project = true docs: blog post on parserOptions.project = true Jul 30, 2023
@JoshuaKGoldberg JoshuaKGoldberg removed the DO NOT MERGE PRs which should not be merged yet label Jul 30, 2023
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review July 30, 2023 22:20
bradzacher
bradzacher previously approved these changes Sep 7, 2023
View reviewed changes
@bradzacher bradzacher added documentation Documentation ("docs") that needs adding/updating 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labels Sep 7, 2023
Josh-Cena
Josh-Cena requested changes Sep 8, 2023
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits

bradzacher
bradzacher previously approved these changes Sep 8, 2023
View reviewed changes
Josh-Cena
Josh-Cena requested changes Sep 8, 2023
View reviewed changes
Josh-Cena
Josh-Cena approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

armano2
armano2 reviewed Sep 12, 2023
View reviewed changes
armano2
armano2 reviewed Sep 12, 2023
View reviewed changes
@JoshuaKGoldberg JoshuaKGoldberg merged commit ded5d21 into typescript-eslint:main Sep 16, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the parser-options-project-true branch September 16, 2023 21:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armano2 armano2 armano2 left review comments

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@bradzacher bradzacher bradzacher left review comments

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Add post on parserOptions.project = true
4 participants
@JoshuaKGoldberg @armano2 @bradzacher @Josh-Cena