Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs(eslint-plugin): replaced the Out-of-date TS error codes in eslint-recommended.ts with the supported-codes #7590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 21, 2023
Merged

docs(eslint-plugin): replaced the Out-of-date TS error codes in eslint-recommended.ts with the supported-codes #7590

merged 2 commits into from
Sep 21, 2023

Conversation

girishsontakke
Copy link
Contributor

PR Checklist

Overview

this PR resolves the issue #7582.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @girishsontakke!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Sep 2, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit dc0b203
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64f5e9ab1fc55700084141ae
😎 Deploy Preview https://deploy-preview-7590--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud
Copy link

nx-cloud bot commented Sep 2, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit dc0b203. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 40 targets

Sent with 💌 from NxCloud.

@girishsontakke girishsontakke changed the title resolve #7582 fix(eslint-plugin): Replaced the Out-of-date TS error codes in eslint-recommended.ts with the supported-codes Sep 2, 2023
@girishsontakke girishsontakke changed the title fix(eslint-plugin): Replaced the Out-of-date TS error codes in eslint-recommended.ts with the supported-codes fix(eslint-plugin): [no-unsafe-negation] replaced the Out-of-date TS error codes in eslint-recommended.ts with the supported-codes Sep 2, 2023
auvred
auvred requested changes Sep 2, 2023
View reviewed changes
Copy link
Member

@auvred auvred left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the other codes according to the existing comments on this PR eslint/eslint#17500

imho these changes don't fix the behavior of the eslint-plugin and [no-unsafe-negation] rule in particular. It's more likely a docs. What do you think?

JoshuaKGoldberg
JoshuaKGoldberg requested changes Sep 2, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What @auvred said 🙂

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Sep 2, 2023
@girishsontakke
Copy link
Contributor Author

Thanks @auvred for the review and the help 🙏. I will add the changes.

@girishsontakke girishsontakke changed the title fix(eslint-plugin): [no-unsafe-negation] replaced the Out-of-date TS error codes in eslint-recommended.ts with the supported-codes docs(eslint-plugin): replaced the Out-of-date TS error codes in eslint-recommended.ts with the supported-codes Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023 •
edited
Loading

Codecov Report

Merging #7590 (dc0b203) into main (4899b95) will not change coverage.
Report is 6 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7590   +/-   ##
=======================================
  Coverage   87.23%   87.23%           
=======================================
  Files         387      387           
  Lines       13401    13401           
  Branches     3962     3962           
=======================================
  Hits        11690    11690           
  Misses       1327     1327           
  Partials      384      384
Flag Coverage Δ
unittest 87.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

auvred
auvred approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@auvred auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I guess that's it

@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Sep 21, 2023
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit dec6cbe into typescript-eslint:main Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@auvred auvred auvred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Out-of-date TS error codes in eslint-recommended.ts
3 participants
@girishsontakke @JoshuaKGoldberg @auvred