Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(website): [playground] improve mobile design #7672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 13, 2023
Merged

chore(website): [playground] improve mobile design #7672

merged 12 commits into from
Nov 13, 2023

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Sep 19, 2023

PR Checklist

Overview

Improve playground design on mobile devices

this change has been extracted from #6656

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Sep 19, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 37bf042
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65522074255767000821c8f9
😎 Deploy Preview https://deploy-preview-7672--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 95 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud
Copy link

nx-cloud bot commented Sep 19, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4529592. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 19 targets

Sent with 💌 from NxCloud.

@armano2 armano2 mentioned this pull request Sep 19, 2023
Closed
bradzacher
bradzacher requested changes Sep 20, 2023
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_20230920-093623.png

The layout seems a bit wrong on mobile - the bottom panel is real small and I can't scroll to see the content.

@armano2
Copy link
Collaborator Author

armano2 commented Sep 20, 2023 •
edited
Loading

can you tell me what browser / os is that, i will check it out

edit, nvm i can see where issue is, after clearing cache i'm able to reproduce it on my phone and in browser

issue seem to be present only in normal build and not in dev mode

edit, issue fixed

@armano2 armano2 requested a review from bradzacher September 20, 2023 11:46
StyleShit
StyleShit suggested changes Sep 27, 2023
View reviewed changes
@bradzacher bradzacher added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Nov 10, 2023
bradzacher
bradzacher approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking good to me from a design perspective and the react code sure looks like react code (it's been a while since I've properly written any react so :nodders:

my only point of feedback is this logic here - chained, mixed logicals within a JSX expression are pretty gnarly to read, but we've already got #7630 for that so :nodders: again

@bradzacher
Copy link
Member

something about this PR is breaking in CI. The initial install step is failing to finish (it was auto-cancelled after SIX hours)

@bradzacher bradzacher added awaiting response Issues waiting for a reply from the OP or another party and removed awaiting response Issues waiting for a reply from the OP or another party labels Nov 11, 2023
@bradzacher bradzacher mentioned this pull request Nov 11, 2023
Merged
3 tasks
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swell, thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 3e243f6 into main Nov 13, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the chore/improve-mobile-playground branch November 13, 2023 16:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StyleShit StyleShit StyleShit requested changes

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge website: playground
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@armano2 @bradzacher @JoshuaKGoldberg @StyleShit