feat(utils): define SourceCode#getScope and deprecate Context#getScope
#7810
Conversation
|
Thanks for the PR, @G-Rath! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
ugh I just realised we won't even be able to use this anyway as we're still stuck on v5 |
|
cc @SimenB FYI in case you notice the warnings in |
|
Closing in favor of #7812 |
PR Checklist
Addresses an existing open issue: fixes #000That issue was marked as accepting prsOverview
I'm still triaging the implications of this over in
eslint-plugin-jest, but for now we can at least get the types added - it's a bit annoying it was added in such a late minor and will be removed in the next immediate major but that's for us to deal with I guess 🤷I assume updates will be needed throughout this codebase but have not actually looked - I know that
unbound-methodneeds updating as our fork of it is omitting deprecation warnings; maybe it would be worth shipping a new util that handles falling back if needed to avoid being a breaking change 🤔(I also can't remember if you prefer using
feat,fix, orchorefor type-only changes - no offense will be taken if you change the title)References: